You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Lin Sun (JIRA)" <ji...@apache.org> on 2008/08/05 19:44:44 UTC

[jira] Created: (GERONIMO-4228) plugininstaller doesn't honor load="false"

plugininstaller doesn't honor load="false"
------------------------------------------

                 Key: GERONIMO-4228
                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
             Project: Geronimo
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: Plugins
    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
            Reporter: Lin Sun
            Assignee: Lin Sun
             Fix For: 2.2


When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) plugininstaller ignores it and still attempt to start the module:

<config-xml-content load="false"/>

This is an issue for app client, which we dont want to start in the server container.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-4228) install plugin from deploy tool doesn't honor load="false"

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun updated GERONIMO-4228:
------------------------------

    Description: 
When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:

<config-xml-content load="false"/>

This is an issue for app client, which we dont want to start in the server container.



  was:
When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) plugininstaller ignores it and still attempt to start the module:

<config-xml-content load="false"/>

This is an issue for app client, which we dont want to start in the server container.



        Summary: install plugin from deploy tool doesn't honor load="false"  (was: plugininstaller doesn't honor load="false")

> install plugin from deploy tool doesn't honor load="false"
> ----------------------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.2
>
>         Attachments: G4228.patch
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-4228) install plugin from deploy tool doesn't honor load="false"

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun updated GERONIMO-4228:
------------------------------

    Attachment: G4228.patch

A proposed patch for this.  

> install plugin from deploy tool doesn't honor load="false"
> ----------------------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.2
>
>         Attachments: G4228.patch
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4228) plugininstaller doesn't honor load="false"

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620425#action_12620425 ] 

Lin Sun commented on GERONIMO-4228:
-----------------------------------

It turned out that this is an issue with plugin installed from command deploy tool (deploy.bat or deploy.sh).   Installing plugin from admin console works fine.

The command deploy tool had some code to start the module after everything is downloaded.   This isn't needed as it is already taken care of by the PluginInstallerGBean, which loads the config-xml-content and starts everything that should have been loaded per the persistentConfigurationLists.   

> plugininstaller doesn't honor load="false"
> ------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.2
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) plugininstaller ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-4228) install plugin from deploy tool doesn't honor load="false"

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun resolved GERONIMO-4228.
-------------------------------

    Resolution: Fixed

Patch committed (see subversion tab).  Thanks Donald for reviewing it.

Tested this with daytrader-tomcat, daytrader-ws-client and daytrader-streamer-client module.

Lin



> install plugin from deploy tool doesn't honor load="false"
> ----------------------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.1.3, 2.2
>
>         Attachments: G4228.patch
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-4228) install plugin from deploy tool doesn't honor load="false"

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated GERONIMO-4228:
-----------------------------------

    Fix Version/s: 2.1.3

Looks okay to me.
Fix also needs to go into the 2.1 branch.

> install plugin from deploy tool doesn't honor load="false"
> ----------------------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.1.3, 2.2
>
>         Attachments: G4228.patch
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-4228) install plugin from deploy tool doesn't honor load="false"

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated GERONIMO-4228:
-----------------------------------

    Patch Info: [Patch Available]

> install plugin from deploy tool doesn't honor load="false"
> ----------------------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.1.3, 2.2
>
>         Attachments: G4228.patch
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-4228) install plugin from deploy tool doesn't honor load="false"

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun closed GERONIMO-4228.
-----------------------------


> install plugin from deploy tool doesn't honor load="false"
> ----------------------------------------------------------
>
>                 Key: GERONIMO-4228
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4228
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.1.3, 2.2
>
>         Attachments: G4228.patch
>
>
> When I configure my plugin to be not loaded, (see below in geronimo-plugin.xml) the deploy install-plugin command ignores it and still attempt to start the module:
> <config-xml-content load="false"/>
> This is an issue for app client, which we dont want to start in the server container.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.