You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shiro.apache.org by "lprimak (via GitHub)" <gi...@apache.org> on 2026/01/28 19:03:10 UTC
[D] [3.0] Integration Testing and samples issues [shiro]
GitHub user lprimak created a discussion: [3.0] Integration Testing and samples issues
Hi,
As you may know, I have been working on getting Shiro 3.x in better shape.
It's going pretty well, but I am getting stuck on the "servlet container" integration tests.
Currently, we have a few different types of integration tests:
Full Jakarta EE Containers:
- Payara (Jakarta EE) tests
- OpenLiberty (Jax-RS and CDI) tests
The Full Jakarta EE containers are now working perfectly in 3.x, and did not have any significant issues / hurdles.
However, the "servlet container" integration tests are giving me all sorts of troubles.
Here are the ones that I can see so far:
- Jetty + https://github.com/mjeanroy/junit-servers
- Tomcat + Meecrowave
So far, only Tomcat + Meecrowave ITs are working properly, but those tests are the minority
Jetty tests are giving me the most trouble.
junit-servers module isn't compatible (yet?) with Jakarta EE 11, which is problem 1.
I filed a bug https://github.com/mjeanroy/junit-servers/issues/964
Jetty itself is hard to deal with, all the changing GAV names and all sorts of dependencies that need to be manually managed (or is there a better way?)
Should we remove Jetty and just use Tomcat+Meecrowave everywhere?
What about Spring / SpringBoot and Guice tests? Do they need Jetty or can they use Meecrowave?
Should we leave Jetty and get things fixed somehow?
What do you think?
GitHub link: https://github.com/apache/shiro/discussions/2482
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [D] [3.0] Integration Testing and samples issues [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
GitHub user lprimak added a comment to the discussion: [3.0] Integration Testing and samples issues
Does that mean we need to drop Meecrowave? Or should we stick with Tomcat + Meecrowave?
GitHub link: https://github.com/apache/shiro/discussions/2482#discussioncomment-15632535
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [D] [3.0] Integration Testing and samples issues [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
GitHub user fpapon added a comment to the discussion: [3.0] Integration Testing and samples issues
I think we can just keep the Tomcat container as it's also use in spring boot.
GitHub link: https://github.com/apache/shiro/discussions/2482#discussioncomment-15632300
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [D] [3.0] Integration Testing and samples issues [shiro]
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
GitHub user rmannibucau added a comment to the discussion: [3.0] Integration Testing and samples issues
my 2cts would be that fusion-http-server can be a lighter server than meecrowave for CDI-less tests - but still neat as surfacing API for Tomcat - and meecrowave is good for CDI layer.
no real need of abstraction IMHO since coverage would be different/overlapping/complementary indirectly.
GitHub link: https://github.com/apache/shiro/discussions/2482#discussioncomment-15633283
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [D] [3.0] Integration Testing and samples issues [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
GitHub user lprimak closed a discussion: [3.0] Integration Testing and samples issues
Hi,
As you may know, I have been working on getting Shiro 3.x in better shape.
It's going pretty well, but I am getting stuck on the "servlet container" integration tests.
Currently, we have a few different types of integration tests:
Full Jakarta EE Containers:
- Payara (Jakarta EE) tests
- OpenLiberty (Jax-RS and CDI) tests
The Full Jakarta EE containers are now working perfectly in 3.x, and did not have any significant issues / hurdles.
However, the "servlet container" integration tests are giving me all sorts of troubles.
Here are the ones that I can see so far:
- Jetty + https://github.com/mjeanroy/junit-servers
- Tomcat + Meecrowave
So far, only Tomcat + Meecrowave ITs are working properly, but those tests are the minority
Jetty tests are giving me the most trouble.
junit-servers module isn't compatible (yet?) with Jakarta EE 11, which is problem 1.
I filed a bug https://github.com/mjeanroy/junit-servers/issues/964
Jetty itself is hard to deal with, all the changing GAV names and all sorts of dependencies that need to be manually managed (or is there a better way?)
Should we remove Jetty and just use Tomcat+Meecrowave everywhere?
What about Spring / SpringBoot and Guice tests? Do they need Jetty or can they use Meecrowave?
Should we leave Jetty and get things fixed somehow?
What do you think?
GitHub link: https://github.com/apache/shiro/discussions/2482
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [D] [3.0] Integration Testing and samples issues [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
GitHub user lprimak added a comment to the discussion: [3.0] Integration Testing and samples issues
Looks like https://github.com/mjeanroy/junit-servers/issues/964 has been updated by Mickael (maintainer) and hopefully this will be resolved by him
GitHub link: https://github.com/apache/shiro/discussions/2482#discussioncomment-15644205
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [D] [3.0] Integration Testing and samples issues [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
GitHub user lprimak closed the discussion with a comment: [3.0] Integration Testing and samples issues
Since all issues were resolved, closing...
GitHub link: https://github.com/apache/shiro/discussions/2482#discussioncomment-15722071
----
This is an automatically sent email for issues@shiro.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@shiro.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org