[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3567: New fakeOrigin testing tool

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3567: New fakeOrigin testing tool
URL: https://github.com/apache/trafficcontrol/pull/3567#discussion_r285330622
 
 

 ##########
 File path: test/fakeOrigin/build/fakeOrigin.spec
 ##########
 @@ -0,0 +1,72 @@
+#
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+# RPM spec file for the test origin fakeOrigin
+#
+
+Summary: fakeOrigin CDN Origin
+Name: fakeOrigin
+Version: %{_version}
+Release: %{_release}
+Group: Base System/System Tools
 
 Review comment:
   I looked really hard for a description of what 'Base System' entails - because it sounds like "stuff you need for the system to work" and idk if that's what feigner is - but it turns out I saw a lot of things saying that RHEL/CentOS versions > 5 have deprecated the `Group` tag, so it may be best to just leave it out entirely ([best source I could find](https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/Packagers_Guide/chap-Packagers_Guide-Spec_File_Reference-Preamble.html))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services