You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/09 01:48:42 UTC
[PR] fix(security): suppress zizmor self-repository false positive for mysql celery worker step [superset]
rusackas opened a new pull request, #44041:
URL: https://github.com/apache/superset/pull/44041
### SUMMARY
Resolves code-scanning alert [#2655](https://github.com/apache/superset/security/code-scanning/2655) (zizmor `self-repository`) at `.github/workflows/superset-python-integrationtest.yml:84`.
zizmor's `self-repository` audit suggests replacing local action references like `./.github/actions/foo` with GitHub's `$/.github/actions/foo` self-repository syntax. That works for actions that live as plain directories in this repo, but `.github/actions/cached-dependencies` is a git submodule (see `.gitmodules`) — `$/` resolves action files directly from the repository content without a real, submodule-aware checkout, so it can't see into the submodule's gitlink and the step would fail to resolve the action.
This keeps the workspace-relative `./` form for the "Start Celery worker" step in the `test-mysql` job, with a scoped `zizmor: ignore[self-repository]` suppression and an explanatory comment, matching the pattern already applied and merged for the other `cached-dependencies` references in this same workflow (e.g. #44018, #44038).
### TESTING INSTRUCTIONS
- `pre-commit run --files .github/workflows/superset-python-integrationtest.yml` passes, including the `zizmor` hook.
- `zizmor .github/workflows/superset-python-integrationtest.yml` no longer flags line 84.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): suppress zizmor self-repository false positive for mysql celery worker step [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44041:
URL: https://github.com/apache/superset/pull/44041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): suppress zizmor self-repository false positive for mysql celery worker step [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44041:
URL: https://github.com/apache/superset/pull/44041#issuecomment-5594534773
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): suppress zizmor self-repository false positive for mysql celery worker step [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44041:
URL: https://github.com/apache/superset/pull/44041#issuecomment-5594671078
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44041?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.34%. Comparing base ([`986b648`](https://app.codecov.io/gh/apache/superset/commit/986b648f1ca2510584091f139a53b05279182bf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3e5ab3d`](https://app.codecov.io/gh/apache/superset/commit/3e5ab3db81b45c93563d302afc542649927e5a1f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (986b648) and HEAD (3e5ab3d). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (986b648) | HEAD (3e5ab3d) |
>|------|------|------|
>|python|7|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44041 +/- ##
===========================================
- Coverage 79.89% 66.34% -13.56%
===========================================
Files 2916 2916
Lines 170755 170755
Branches 39569 39569
===========================================
- Hits 136429 113289 -23140
- Misses 31808 55096 +23288
+ Partials 2518 2370 -148
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.24% <ø> (-27.10%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.11% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/44041/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44041?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org