You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Eduardo Romeiro <ro...@gmail.com> on 2013/01/17 15:23:11 UTC

Review Request: Rave 863 Made featured widgets visually distinguishable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9006/
-----------------------------------------------------------

Review request for rave.


Description
-------

Updated less file, increased specificity of selector for featured widgets.


This addresses bug Rave-863.
    https://issues.apache.org/jira/browse/Rave-863


Diffs
-----

  /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1433501 

Diff: https://reviews.apache.org/r/9006/diff/


Testing
-------


Thanks,

Eduardo Romeiro


Re: Review Request: Rave 863 Made featured widgets visually distinguishable

Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9006/#review15569
-----------------------------------------------------------

Ship it!


Thanks for the patch.  I will commit it soon.


/trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less
<https://reviews.apache.org/r/9006/#comment33650>

    not sure the color is a very good match anymore, but I don't think that is a blocker.


- Matt Franklin


On Jan. 17, 2013, 2:23 p.m., Eduardo Romeiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9006/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 2:23 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Updated less file, increased specificity of selector for featured widgets.
> 
> 
> This addresses bug Rave-863.
>     https://issues.apache.org/jira/browse/Rave-863
> 
> 
> Diffs
> -----
> 
>   /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1433501 
> 
> Diff: https://reviews.apache.org/r/9006/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eduardo Romeiro
> 
>


Re: Review Request: Rave 863 Made featured widgets visually distinguishable

Posted by Eduardo Romeiro <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9006/
-----------------------------------------------------------

(Updated Jan. 17, 2013, 2:23 p.m.)


Review request for rave.


Description
-------

Updated less file, increased specificity of selector for featured widgets.


This addresses bug Rave-863.
    https://issues.apache.org/jira/browse/Rave-863


Diffs
-----

  /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1433501 

Diff: https://reviews.apache.org/r/9006/diff/


Testing
-------


Thanks,

Eduardo Romeiro


Re: Review Request: Rave 863 Made featured widgets visually distinguishable

Posted by Eduardo Romeiro <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9006/
-----------------------------------------------------------

(Updated Jan. 17, 2013, 2:23 p.m.)


Review request for rave.


Description
-------

Updated less file, increased specificity of selector for featured widgets.


This addresses bug Rave-863.
    https://issues.apache.org/jira/browse/Rave-863


Diffs
-----

  /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1433501 

Diff: https://reviews.apache.org/r/9006/diff/


Testing
-------


Thanks,

Eduardo Romeiro