You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/29 09:26:16 UTC
[GitHub] [incubator-doris] Aiden-Dong opened a new pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Aiden-Dong opened a new pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531
## Proposed changes
Close related #issue (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on a change in pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
jackwener commented on a change in pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#discussion_r776591586
##########
File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisStreamLoadSink.scala
##########
@@ -81,14 +83,24 @@ private[sql] class DorisStreamLoadSink(sqlContext: SQLContext, settings: SparkSe
catch {
case e: Exception =>
try {
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ //If the current BE node fails to execute Stream Load, randomly switch to other BE nodes and try again
+ dorisStreamLoader.setHostPort(RestService.randomBackendV2(settings,logger))
Thread.sleep(1000 * i)
} catch {
case ex: InterruptedException =>
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
Thread.currentThread.interrupt()
throw new IOException("unable to flush; interrupted while doing another attempt", e)
}
}
}
+
+ if(!rowsBuffer.isEmpty){
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr)
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#issuecomment-1002482131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#issuecomment-1008255886
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Aiden-Dong commented on a change in pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
Aiden-Dong commented on a change in pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#discussion_r779270303
##########
File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisStreamLoadSink.scala
##########
@@ -81,14 +83,24 @@ private[sql] class DorisStreamLoadSink(sqlContext: SQLContext, settings: SparkSe
catch {
case e: Exception =>
try {
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ //If the current BE node fails to execute Stream Load, randomly switch to other BE nodes and try again
+ dorisStreamLoader.setHostPort(RestService.randomBackendV2(settings,logger))
Thread.sleep(1000 * i)
} catch {
case ex: InterruptedException =>
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
Thread.currentThread.interrupt()
throw new IOException("unable to flush; interrupted while doing another attempt", e)
}
}
}
+
+ if(!rowsBuffer.isEmpty){
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangshuo128 commented on a change in pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
wangshuo128 commented on a change in pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#discussion_r776580497
##########
File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisStreamLoadSink.scala
##########
@@ -81,14 +83,24 @@ private[sql] class DorisStreamLoadSink(sqlContext: SQLContext, settings: SparkSe
catch {
case e: Exception =>
try {
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ //If the current BE node fails to execute Stream Load, randomly switch to other BE nodes and try again
+ dorisStreamLoader.setHostPort(RestService.randomBackendV2(settings,logger))
Thread.sleep(1000 * i)
} catch {
case ex: InterruptedException =>
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
Thread.currentThread.interrupt()
throw new IOException("unable to flush; interrupted while doing another attempt", e)
}
}
}
+
+ if(!rowsBuffer.isEmpty){
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr)
+ throw new IOException(errMsg)
Review comment:
```suggestion
throw new IOException(s"Failed to load data on BE: ${dorisStreamLoader.getLoadUrlStr} node and exceeded the max retry times.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#discussion_r778519928
##########
File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisStreamLoadSink.scala
##########
@@ -81,14 +83,24 @@ private[sql] class DorisStreamLoadSink(sqlContext: SQLContext, settings: SparkSe
catch {
case e: Exception =>
try {
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ //If the current BE node fails to execute Stream Load, randomly switch to other BE nodes and try again
+ dorisStreamLoader.setHostPort(RestService.randomBackendV2(settings,logger))
Thread.sleep(1000 * i)
} catch {
case ex: InterruptedException =>
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
Thread.currentThread.interrupt()
throw new IOException("unable to flush; interrupted while doing another attempt", e)
}
}
}
+
+ if(!rowsBuffer.isEmpty){
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
Review comment:
Merge these 2 `logger.warn`
##########
File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisSourceProvider.scala
##########
@@ -97,14 +100,24 @@ private[sql] class DorisSourceProvider extends DataSourceRegister
catch {
case e: Exception =>
try {
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ //If the current BE node fails to execute Stream Load, randomly switch to other BE nodes and try again
+ dorisStreamLoader.setHostPort(RestService.randomBackendV2(sparkSettings,logger))
Thread.sleep(1000 * i)
} catch {
case ex: InterruptedException =>
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
Thread.currentThread.interrupt()
throw new IOException("unable to flush; interrupted while doing another attempt", e)
}
}
}
+
+ if(!rowsBuffer.isEmpty){
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
Review comment:
merge these 2 `logger.warn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#issuecomment-1003220499
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on a change in pull request #7531: Throw an exception to spark when the data push fails and there are too many retries
Posted by GitBox <gi...@apache.org>.
jackwener commented on a change in pull request #7531:
URL: https://github.com/apache/incubator-doris/pull/7531#discussion_r776581572
##########
File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisStreamLoadSink.scala
##########
@@ -81,14 +83,24 @@ private[sql] class DorisStreamLoadSink(sqlContext: SQLContext, settings: SparkSe
catch {
case e: Exception =>
try {
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ //If the current BE node fails to execute Stream Load, randomly switch to other BE nodes and try again
+ dorisStreamLoader.setHostPort(RestService.randomBackendV2(settings,logger))
Thread.sleep(1000 * i)
} catch {
case ex: InterruptedException =>
+ logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer))
Thread.currentThread.interrupt()
throw new IOException("unable to flush; interrupted while doing another attempt", e)
}
}
}
+
+ if(!rowsBuffer.isEmpty){
+ logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr)
+ var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr)
+ throw new IOException(errMsg)
Review comment:
```suggestion
throw new IOException(s"Failed to load data on BE: ${dorisStreamLoader.getLoadUrlStr} node and exceeded the max retry times.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org