You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/04/16 07:51:39 UTC
[GitHub] [celix] Oipo opened a new pull request #199: Bugfix/zmq fixes
Oipo opened a new pull request #199: Bugfix/zmq fixes
URL: https://github.com/apache/celix/pull/199
I think this fixes most of the asan mentions in pubsub. However, the deadlock in #188 might still be in here somewhere, as I cannot currently trigger it with the specific test case we have for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes commented on a change in pull request #199:
Bugfix/zmq fixes
Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #199: Bugfix/zmq fixes
URL: https://github.com/apache/celix/pull/199#discussion_r409504751
##########
File path: bundles/pubsub/examples/pubsub/interceptors/src/ps_interceptor_activator.c
##########
@@ -26,52 +26,54 @@
struct interceptorActivator {
first_interceptor_t *interceptor;
uint64_t interceptorSvcId;
+ pubsub_interceptor_t *interceptorSvc;
second_interceptor_t *secondInterceptor;
uint64_t secondInterceptorSvcId;
+ pubsub_interceptor_t *secondInterceptorSvc;
Review comment:
I know this is just a name change, but this does not need to be a pointer.
so:
```C
struct interceptorActivator {
uint64_t interceptorSvcId;
pubsub_interceptor_t interceptorSvc;
uint64_t secondInterceptorSvcId;
pubsub_interceptor_t secondInterceptorSvc;
};
```
should also works and save two malloc/callocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes commented on a change in pull request #199:
Bugfix/zmq fixes
Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #199: Bugfix/zmq fixes
URL: https://github.com/apache/celix/pull/199#discussion_r409505483
##########
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
##########
@@ -549,6 +563,9 @@ static int psa_zmq_topicPublicationSend(void* handle, unsigned int msgTypeId, co
void *payloadData = NULL;
size_t payloadLength = 0;
entry->protSer->encodePayload(entry->protSer->handle, &message, &payloadData, &payloadLength);
+ if(payloadLength > 1000000) {
+ printf("ERR LARGE PAYLOAD DETECTED\n");
Review comment:
psa zmq should have log macro available->
L_WARN("...");
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes merged pull request #199: Bugfix/zmq fixes #191
Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #199: Bugfix/zmq fixes #191
URL: https://github.com/apache/celix/pull/199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services