You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Michael Rasmussen <ra...@hotmail.com> on 2004/05/26 03:11:09 UTC
[PATCH] JavascriptValidatorTag.java Updated to commons-validator dev 1.2
I updated the JavascriptValidatorTag.java file to add to reflect the changes
to commons-validator. There is still a warning having to do with the
servlet api methods being deprecated. This is not related to
commons-validator however. This change puts struts-dev 1.2 and struts-faces
0.5 on the same version of the validator.jar. This seems natural to me. It
is both typed below and attached. Is this the correct way to submit a
patch?
Index: JavascriptValidatorTag.java
===================================================================
RCS file:
/home/cvspublic/jakarta-struts/contrib/struts-faces/src/java/org/apache/stru
ts/faces/taglib/JavascriptValidatorTag.java,v
retrieving revision 1.4
diff -r1.4 JavascriptValidatorTag.java
41c41
< import org.apache.commons.validator.ValidatorUtil;
---
> import org.apache.commons.validator.util.ValidatorUtils;
278c278
< Form form = resources.get(locale, formName);
---
> Form form = resources.getForm(locale, formName);
293c293
< for (Iterator x = field.getDependencies().iterator();
x.hasNext();) {
---
> for (Iterator x =
field.getDependencyList().iterator(); x.hasNext();) {
341c341
< return va1.getDependencies().size() -
va2.getDependencies().size();
---
> return va1.getDependencyList().size() -
va2.getDependencyList().size();
422c422
< + ValidatorUtil.replace(
---
> + ValidatorUtils.replace(
432c432
< + ValidatorUtil.replace(
---
> + ValidatorUtils.replace(
442c442
< + ValidatorUtil.replace(
---
> + ValidatorUtils.replace(
453c453
< + ValidatorUtil.replace(
---
> + ValidatorUtils.replace(
463c463
< + ValidatorUtil.replace(
---
> + ValidatorUtils.replace(
Re: [PATCH] JavascriptValidatorTag.java Updated to
commons-validator dev 1.2
Posted by Joe Germuska <Jo...@Germuska.com>.
Note that that page actually advises emailing "the appropriate
developer list". However, it's true that for Struts we've always
preferred patches attached to Bugzilla tickets.
I guess as part of setting up Struts.apache.org we can adapt that
page to be more clear about how we prefer to handle patches.
Joe
At 2:20 AM +0100 5/26/04, Niall Pemberton wrote:
>Best to open a Bugzilla ticket and attach the patch there, that way it won't
>get lost. Also preferred format is "cvs diff -u"
>
>See:
>
> http://jakarta.apache.org/site/bugs.html
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Imagine if every Thursday your shoes exploded if you tied them
the usual way. This happens to us all the time with computers, and
nobody thinks of complaining."
-- Jef Raskin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
RE: [PATCH] JavascriptValidatorTag.java Updated to
commons-validator dev 1.2
Posted by Joe Germuska <Jo...@Germuska.com>.
At 11:09 PM -0500 5/25/04, Michael Rasmussen wrote:
>Thanks for the correction.
>I want to make sure I am posting this to bugzilla correctly, so here is the
>new command:
>
>RCS file:
>/home/cvspublic/jakarta-struts/contrib/struts-faces/src/java/org/apache/stru
>ts/faces/taglib/JavascriptValidatorTag.java,v
>retrieving revision 1.4
>diff -u -r1.4 JavascriptValidatorTag.java
>
>I will send up the patch tomorrow if this is the correct command to use.
>Note: I am using Eclipse to generate my patches. I am still trying to
>figure out how to do this correctly. I am a little leary of the -r1.4 as
>that is not in the Jakarta explanation of submitting patches. Well let me
>know.
>Michael
>
>P.S. Sorry for the annoying newbie questions.
Questions that yield patch-contributing developers are never annoying!
You shouldn't need to specify the version number -- [diff -u
relative/path/to/File] should have CVS produce the diffs between your
local copy of [relative/path/to/File] and the last version you
checked out.
Thanks for going to the trouble.
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Imagine if every Thursday your shoes exploded if you tied them
the usual way. This happens to us all the time with computers, and
nobody thinks of complaining."
-- Jef Raskin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
RE: [PATCH] JavascriptValidatorTag.java Updated to commons-validator dev 1.2
Posted by Michael Rasmussen <ra...@hotmail.com>.
Thanks for the correction.
I want to make sure I am posting this to bugzilla correctly, so here is the
new command:
RCS file:
/home/cvspublic/jakarta-struts/contrib/struts-faces/src/java/org/apache/stru
ts/faces/taglib/JavascriptValidatorTag.java,v
retrieving revision 1.4
diff -u -r1.4 JavascriptValidatorTag.java
I will send up the patch tomorrow if this is the correct command to use.
Note: I am using Eclipse to generate my patches. I am still trying to
figure out how to do this correctly. I am a little leary of the -r1.4 as
that is not in the Jakarta explanation of submitting patches. Well let me
know.
Michael
P.S. Sorry for the annoying newbie questions.
-----Original Message-----
From: Niall Pemberton [mailto:niall.pemberton@blueyonder.co.uk]
Sent: Tuesday, May 25, 2004 8:20 PM
To: Struts Developers List
Subject: Re: [PATCH] JavascriptValidatorTag.java Updated to
commons-validator dev 1.2
Best to open a Bugzilla ticket and attach the patch there, that way it won't
get lost. Also preferred format is "cvs diff -u"
See:
http://jakarta.apache.org/site/bugs.html
Niall
----- Original Message -----
From: "Michael Rasmussen" <ra...@hotmail.com>
To: "'Struts Developers List'" <de...@struts.apache.org>
Sent: Wednesday, May 26, 2004 2:11 AM
Subject: [PATCH] JavascriptValidatorTag.java Updated to commons-validator
dev 1.2
> I updated the JavascriptValidatorTag.java file to add to reflect the
changes
> to commons-validator. There is still a warning having to do with the
> servlet api methods being deprecated. This is not related to
> commons-validator however. This change puts struts-dev 1.2 and
struts-faces
> 0.5 on the same version of the validator.jar. This seems natural to me.
It
> is both typed below and attached. Is this the correct way to submit a
> patch?
>
>
>
> Index: JavascriptValidatorTag.java
> ===================================================================
> RCS file:
>
/home/cvspublic/jakarta-struts/contrib/struts-faces/src/java/org/apache/stru
> ts/faces/taglib/JavascriptValidatorTag.java,v
> retrieving revision 1.4
> diff -r1.4 JavascriptValidatorTag.java
> 41c41
> < import org.apache.commons.validator.ValidatorUtil;
> ---
> > import org.apache.commons.validator.util.ValidatorUtils;
> 278c278
> < Form form = resources.get(locale, formName);
> ---
> > Form form = resources.getForm(locale, formName);
> 293c293
> < for (Iterator x =
field.getDependencies().iterator();
> x.hasNext();) {
> ---
> > for (Iterator x =
> field.getDependencyList().iterator(); x.hasNext();) {
> 341c341
> < return va1.getDependencies().size() -
> va2.getDependencies().size();
> ---
> > return va1.getDependencyList().size() -
> va2.getDependencyList().size();
> 422c422
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 432c432
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 442c442
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 453c453
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 463c463
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
>
----------------------------------------------------------------------------
----
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [PATCH] JavascriptValidatorTag.java Updated to commons-validator dev 1.2
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
Best to open a Bugzilla ticket and attach the patch there, that way it won't
get lost. Also preferred format is "cvs diff -u"
See:
http://jakarta.apache.org/site/bugs.html
Niall
----- Original Message -----
From: "Michael Rasmussen" <ra...@hotmail.com>
To: "'Struts Developers List'" <de...@struts.apache.org>
Sent: Wednesday, May 26, 2004 2:11 AM
Subject: [PATCH] JavascriptValidatorTag.java Updated to commons-validator
dev 1.2
> I updated the JavascriptValidatorTag.java file to add to reflect the
changes
> to commons-validator. There is still a warning having to do with the
> servlet api methods being deprecated. This is not related to
> commons-validator however. This change puts struts-dev 1.2 and
struts-faces
> 0.5 on the same version of the validator.jar. This seems natural to me.
It
> is both typed below and attached. Is this the correct way to submit a
> patch?
>
>
>
> Index: JavascriptValidatorTag.java
> ===================================================================
> RCS file:
>
/home/cvspublic/jakarta-struts/contrib/struts-faces/src/java/org/apache/stru
> ts/faces/taglib/JavascriptValidatorTag.java,v
> retrieving revision 1.4
> diff -r1.4 JavascriptValidatorTag.java
> 41c41
> < import org.apache.commons.validator.ValidatorUtil;
> ---
> > import org.apache.commons.validator.util.ValidatorUtils;
> 278c278
> < Form form = resources.get(locale, formName);
> ---
> > Form form = resources.getForm(locale, formName);
> 293c293
> < for (Iterator x =
field.getDependencies().iterator();
> x.hasNext();) {
> ---
> > for (Iterator x =
> field.getDependencyList().iterator(); x.hasNext();) {
> 341c341
> < return va1.getDependencies().size() -
> va2.getDependencies().size();
> ---
> > return va1.getDependencyList().size() -
> va2.getDependencyList().size();
> 422c422
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 432c432
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 442c442
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 453c453
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
> 463c463
> < + ValidatorUtil.replace(
> ---
> > + ValidatorUtils.replace(
>
----------------------------------------------------------------------------
----
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org