You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by mark stephens <ma...@idrsolutions.com> on 2017/10/13 14:15:59 UTC
Request for clarification on review process on NetBeans with pngs and
other odd files found
I have reviewed my first module (performance), and found some pngs and xml files in a package without headers in src/threaddemo/util/doc-files
What is the correct way to handle these?
Regards,
MArk
Re: Idiots guy to making a change for a module code change
Posted by Geertjan Wielenga <ge...@googlemail.com>.
OK, I have taken the 'performance' module.
Gj
On Tue, Oct 31, 2017 at 4:34 PM, mark stephens <
markstephens@idrsolutions.com> wrote:
>
>
> > On 31 Oct 2017, at 14:41, Geertjan Wielenga <
> geertjan.wielenga@googlemail.com> wrote:
> >
> > No worries at all!
> >
> > So, can we take your name off and have someone else do those assigned to
> > you?
> >
> > Thanks,
> >
> > Gj
>
> Yes please.
>
> MArk
> >
> > On Tue, Oct 31, 2017 at 3:36 PM, mark stephens <
> > markstephens@idrsolutions.com> wrote:
> >
> >>
> >>
> >>> On 31 Oct 2017, at 12:56, Geertjan Wielenga <
> >> geertjan.wielenga@googlemail.com> wrote:
> >>>
> >>> Hi Mark,
> >>>
> >>> If you don't have the bandwidth for reviewing the module, please let us
> >>> know, so we can complete this one.
> >>>
> >>> Thanks,
> >>>
> >>> Gj
> >>
> >> I did not have time to complete. It just needs the header file adding to
> >> the zipped dir in test_docs.
> >>
> >> Apologies for holding up the process.
> >>
> >> MArk
> >>
> >>>
> >>> On Fri, Oct 27, 2017 at 1:11 PM, mark stephens <
> >>> markstephens@idrsolutions.com> wrote:
> >>>
> >>>> Thank-you. Just what I was looking for….
> >>>>
> >>>> Regards,
> >>>>
> >>>> MArk
> >>>>
> >>>>> On 27 Oct 2017, at 11:20, Eric Barboni <Er...@irit.fr> wrote:
> >>>>>
> >>>>> Hi,
> >>>>> WIP for an idiot guide https://cwiki.apache.org/
> >>>> confluence/pages/viewpage.action?pageId=74681408
> >>>>>
> >>>>> Regards
> >>>>> Eric (less idiot but still not fluent :^p )
> >>>>>
> >>>>>
> >>>>> -----Message d'origine-----
> >>>>> De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
> >>>>> Envoyé : vendredi 27 octobre 2017 12:12
> >>>>> À : dev@netbeans.incubator.apache.org
> >>>>> Objet : Re: Idiots guy to making a change for a module code change
> >>>>>
> >>>>> If you commit changes to the same branch in your fork, that should
> work
> >>>> fine.
> >>>>>
> >>>>> Gj
> >>>>>
> >>>>> On Fri, Oct 27, 2017 at 12:09 PM, mark stephens <
> >>>> markstephens@idrsolutions.com> wrote:
> >>>>>
> >>>>>> In reviewing the modules, I have one which needs a change (adding a
> >>>>>> header). Is there an idiots guide so I can follow the steps to
> >>>>>> submitting a change for the first time.
> >>>>>>
> >>>>>> Kind Regards,
> >>>>>>
> >>>>>> MArk
> >>>>>
> >>>>
> >>>>
> >>
> >>
>
>
Re: Idiots guy to making a change for a module code change
Posted by mark stephens <ma...@idrsolutions.com>.
> On 31 Oct 2017, at 14:41, Geertjan Wielenga <ge...@googlemail.com> wrote:
>
> No worries at all!
>
> So, can we take your name off and have someone else do those assigned to
> you?
>
> Thanks,
>
> Gj
Yes please.
MArk
>
> On Tue, Oct 31, 2017 at 3:36 PM, mark stephens <
> markstephens@idrsolutions.com> wrote:
>
>>
>>
>>> On 31 Oct 2017, at 12:56, Geertjan Wielenga <
>> geertjan.wielenga@googlemail.com> wrote:
>>>
>>> Hi Mark,
>>>
>>> If you don't have the bandwidth for reviewing the module, please let us
>>> know, so we can complete this one.
>>>
>>> Thanks,
>>>
>>> Gj
>>
>> I did not have time to complete. It just needs the header file adding to
>> the zipped dir in test_docs.
>>
>> Apologies for holding up the process.
>>
>> MArk
>>
>>>
>>> On Fri, Oct 27, 2017 at 1:11 PM, mark stephens <
>>> markstephens@idrsolutions.com> wrote:
>>>
>>>> Thank-you. Just what I was looking for….
>>>>
>>>> Regards,
>>>>
>>>> MArk
>>>>
>>>>> On 27 Oct 2017, at 11:20, Eric Barboni <Er...@irit.fr> wrote:
>>>>>
>>>>> Hi,
>>>>> WIP for an idiot guide https://cwiki.apache.org/
>>>> confluence/pages/viewpage.action?pageId=74681408
>>>>>
>>>>> Regards
>>>>> Eric (less idiot but still not fluent :^p )
>>>>>
>>>>>
>>>>> -----Message d'origine-----
>>>>> De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
>>>>> Envoyé : vendredi 27 octobre 2017 12:12
>>>>> À : dev@netbeans.incubator.apache.org
>>>>> Objet : Re: Idiots guy to making a change for a module code change
>>>>>
>>>>> If you commit changes to the same branch in your fork, that should work
>>>> fine.
>>>>>
>>>>> Gj
>>>>>
>>>>> On Fri, Oct 27, 2017 at 12:09 PM, mark stephens <
>>>> markstephens@idrsolutions.com> wrote:
>>>>>
>>>>>> In reviewing the modules, I have one which needs a change (adding a
>>>>>> header). Is there an idiots guide so I can follow the steps to
>>>>>> submitting a change for the first time.
>>>>>>
>>>>>> Kind Regards,
>>>>>>
>>>>>> MArk
>>>>>
>>>>
>>>>
>>
>>
Re: Idiots guy to making a change for a module code change
Posted by Geertjan Wielenga <ge...@googlemail.com>.
No worries at all!
So, can we take your name off and have someone else do those assigned to
you?
Thanks,
Gj
On Tue, Oct 31, 2017 at 3:36 PM, mark stephens <
markstephens@idrsolutions.com> wrote:
>
>
> > On 31 Oct 2017, at 12:56, Geertjan Wielenga <
> geertjan.wielenga@googlemail.com> wrote:
> >
> > Hi Mark,
> >
> > If you don't have the bandwidth for reviewing the module, please let us
> > know, so we can complete this one.
> >
> > Thanks,
> >
> > Gj
>
> I did not have time to complete. It just needs the header file adding to
> the zipped dir in test_docs.
>
> Apologies for holding up the process.
>
> MArk
>
> >
> > On Fri, Oct 27, 2017 at 1:11 PM, mark stephens <
> > markstephens@idrsolutions.com> wrote:
> >
> >> Thank-you. Just what I was looking for….
> >>
> >> Regards,
> >>
> >> MArk
> >>
> >>> On 27 Oct 2017, at 11:20, Eric Barboni <Er...@irit.fr> wrote:
> >>>
> >>> Hi,
> >>> WIP for an idiot guide https://cwiki.apache.org/
> >> confluence/pages/viewpage.action?pageId=74681408
> >>>
> >>> Regards
> >>> Eric (less idiot but still not fluent :^p )
> >>>
> >>>
> >>> -----Message d'origine-----
> >>> De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
> >>> Envoyé : vendredi 27 octobre 2017 12:12
> >>> À : dev@netbeans.incubator.apache.org
> >>> Objet : Re: Idiots guy to making a change for a module code change
> >>>
> >>> If you commit changes to the same branch in your fork, that should work
> >> fine.
> >>>
> >>> Gj
> >>>
> >>> On Fri, Oct 27, 2017 at 12:09 PM, mark stephens <
> >> markstephens@idrsolutions.com> wrote:
> >>>
> >>>> In reviewing the modules, I have one which needs a change (adding a
> >>>> header). Is there an idiots guide so I can follow the steps to
> >>>> submitting a change for the first time.
> >>>>
> >>>> Kind Regards,
> >>>>
> >>>> MArk
> >>>
> >>
> >>
>
>
Re: Idiots guy to making a change for a module code change
Posted by mark stephens <ma...@idrsolutions.com>.
> On 31 Oct 2017, at 12:56, Geertjan Wielenga <ge...@googlemail.com> wrote:
>
> Hi Mark,
>
> If you don't have the bandwidth for reviewing the module, please let us
> know, so we can complete this one.
>
> Thanks,
>
> Gj
I did not have time to complete. It just needs the header file adding to the zipped dir in test_docs.
Apologies for holding up the process.
MArk
>
> On Fri, Oct 27, 2017 at 1:11 PM, mark stephens <
> markstephens@idrsolutions.com> wrote:
>
>> Thank-you. Just what I was looking for….
>>
>> Regards,
>>
>> MArk
>>
>>> On 27 Oct 2017, at 11:20, Eric Barboni <Er...@irit.fr> wrote:
>>>
>>> Hi,
>>> WIP for an idiot guide https://cwiki.apache.org/
>> confluence/pages/viewpage.action?pageId=74681408
>>>
>>> Regards
>>> Eric (less idiot but still not fluent :^p )
>>>
>>>
>>> -----Message d'origine-----
>>> De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
>>> Envoyé : vendredi 27 octobre 2017 12:12
>>> À : dev@netbeans.incubator.apache.org
>>> Objet : Re: Idiots guy to making a change for a module code change
>>>
>>> If you commit changes to the same branch in your fork, that should work
>> fine.
>>>
>>> Gj
>>>
>>> On Fri, Oct 27, 2017 at 12:09 PM, mark stephens <
>> markstephens@idrsolutions.com> wrote:
>>>
>>>> In reviewing the modules, I have one which needs a change (adding a
>>>> header). Is there an idiots guide so I can follow the steps to
>>>> submitting a change for the first time.
>>>>
>>>> Kind Regards,
>>>>
>>>> MArk
>>>
>>
>>
Re: Idiots guy to making a change for a module code change
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Hi Mark,
If you don't have the bandwidth for reviewing the module, please let us
know, so we can complete this one.
Thanks,
Gj
On Fri, Oct 27, 2017 at 1:11 PM, mark stephens <
markstephens@idrsolutions.com> wrote:
> Thank-you. Just what I was looking for….
>
> Regards,
>
> MArk
>
> > On 27 Oct 2017, at 11:20, Eric Barboni <Er...@irit.fr> wrote:
> >
> > Hi,
> > WIP for an idiot guide https://cwiki.apache.org/
> confluence/pages/viewpage.action?pageId=74681408
> >
> > Regards
> > Eric (less idiot but still not fluent :^p )
> >
> >
> > -----Message d'origine-----
> > De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
> > Envoyé : vendredi 27 octobre 2017 12:12
> > À : dev@netbeans.incubator.apache.org
> > Objet : Re: Idiots guy to making a change for a module code change
> >
> > If you commit changes to the same branch in your fork, that should work
> fine.
> >
> > Gj
> >
> > On Fri, Oct 27, 2017 at 12:09 PM, mark stephens <
> markstephens@idrsolutions.com> wrote:
> >
> >> In reviewing the modules, I have one which needs a change (adding a
> >> header). Is there an idiots guide so I can follow the steps to
> >> submitting a change for the first time.
> >>
> >> Kind Regards,
> >>
> >> MArk
> >
>
>
Re: Idiots guy to making a change for a module code change
Posted by mark stephens <ma...@idrsolutions.com>.
Thank-you. Just what I was looking for….
Regards,
MArk
> On 27 Oct 2017, at 11:20, Eric Barboni <Er...@irit.fr> wrote:
>
> Hi,
> WIP for an idiot guide https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408
>
> Regards
> Eric (less idiot but still not fluent :^p )
>
>
> -----Message d'origine-----
> De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
> Envoyé : vendredi 27 octobre 2017 12:12
> À : dev@netbeans.incubator.apache.org
> Objet : Re: Idiots guy to making a change for a module code change
>
> If you commit changes to the same branch in your fork, that should work fine.
>
> Gj
>
> On Fri, Oct 27, 2017 at 12:09 PM, mark stephens < markstephens@idrsolutions.com> wrote:
>
>> In reviewing the modules, I have one which needs a change (adding a
>> header). Is there an idiots guide so I can follow the steps to
>> submitting a change for the first time.
>>
>> Kind Regards,
>>
>> MArk
>
RE: Idiots guy to making a change for a module code change
Posted by Eric Barboni <Er...@irit.fr>.
Hi,
WIP for an idiot guide https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408
Regards
Eric (less idiot but still not fluent :^p )
-----Message d'origine-----
De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
Envoyé : vendredi 27 octobre 2017 12:12
À : dev@netbeans.incubator.apache.org
Objet : Re: Idiots guy to making a change for a module code change
If you commit changes to the same branch in your fork, that should work fine.
Gj
On Fri, Oct 27, 2017 at 12:09 PM, mark stephens < markstephens@idrsolutions.com> wrote:
> In reviewing the modules, I have one which needs a change (adding a
> header). Is there an idiots guide so I can follow the steps to
> submitting a change for the first time.
>
> Kind Regards,
>
> MArk
Re: Idiots guy to making a change for a module code change
Posted by Geertjan Wielenga <ge...@googlemail.com>.
If you commit changes to the same branch in your fork, that should work
fine.
Gj
On Fri, Oct 27, 2017 at 12:09 PM, mark stephens <
markstephens@idrsolutions.com> wrote:
> In reviewing the modules, I have one which needs a change (adding a
> header). Is there an idiots guide so I can follow the steps to submitting a
> change for the first time.
>
> Kind Regards,
>
> MArk
Idiots guy to making a change for a module code change
Posted by mark stephens <ma...@idrsolutions.com>.
In reviewing the modules, I have one which needs a change (adding a header). Is there an idiots guide so I can follow the steps to submitting a change for the first time.
Kind Regards,
MArk
Re: Request for clarification on review process on NetBeans with pngs
and other odd files found
Posted by Emilian Bold <em...@gmail.com>.
That's an ArgoUML file most likely. Don't unzip and attach headers to
it. We wouldn't do the same for .odt files, no? (which are also zip
files)
--emi
On Fri, Oct 20, 2017 at 5:12 PM, mark stephens
<ma...@idrsolutions.com> wrote:
>
>
>> On 13 Oct 2017, at 15:46, Antonio Vieiro <an...@vieiro.net> wrote:
>>
>> Hi,
>>
>> - Just ignore image files (png/jpg/gif).
>> - Add a comment to the xml files (you can copy it from nproject/project.xml).
>>
>> Greetings & thanks,
>> Antonio
>
> It is actually a zip file (TwoWaySupport.zargo) containing some xml and pgml files in doc-files. Should this be deleted or unzipped and rezipped with headers attached?
>
> MArk
>>
>>
>>> El 13 oct 2017, a las 16:15, mark stephens <ma...@idrsolutions.com> escribió:
>>>
>>> I have reviewed my first module (performance), and found some pngs and xml files in a package without headers in src/threaddemo/util/doc-files
>>>
>>> What is the correct way to handle these?
>>>
>>> Regards,
>>>
>>> MArk
>>
>
Re: Request for clarification on review process on NetBeans with pngs
and other odd files found
Posted by mark stephens <ma...@idrsolutions.com>.
> On 13 Oct 2017, at 15:46, Antonio Vieiro <an...@vieiro.net> wrote:
>
> Hi,
>
> - Just ignore image files (png/jpg/gif).
> - Add a comment to the xml files (you can copy it from nproject/project.xml).
>
> Greetings & thanks,
> Antonio
It is actually a zip file (TwoWaySupport.zargo) containing some xml and pgml files in doc-files. Should this be deleted or unzipped and rezipped with headers attached?
MArk
>
>
>> El 13 oct 2017, a las 16:15, mark stephens <ma...@idrsolutions.com> escribió:
>>
>> I have reviewed my first module (performance), and found some pngs and xml files in a package without headers in src/threaddemo/util/doc-files
>>
>> What is the correct way to handle these?
>>
>> Regards,
>>
>> MArk
>
Re: Request for clarification on review process on NetBeans with pngs
and other odd files found
Posted by Antonio Vieiro <an...@vieiro.net>.
Hi,
- Just ignore image files (png/jpg/gif).
- Add a comment to the xml files (you can copy it from nproject/project.xml).
Greetings & thanks,
Antonio
> El 13 oct 2017, a las 16:15, mark stephens <ma...@idrsolutions.com> escribió:
>
> I have reviewed my first module (performance), and found some pngs and xml files in a package without headers in src/threaddemo/util/doc-files
>
> What is the correct way to handle these?
>
> Regards,
>
> MArk