[Impala-ASF-CR] IMPALA-10851: Codegen for structs

["Csaba Ringhofer (Code Review)" <ge...@cloudera.org>]

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 )

Change subject: IMPALA-10851: Codegen for structs
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/codegen/codegen-anyval-read-write-info.h
File be/src/codegen/codegen-anyval-read-write-info.h:

http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/codegen/codegen-anyval-read-write-info.h@91
PS9, Line 91: CodegenAnyValReadWriteInfo
name idea: CodegenNullableValueRead?


http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/exec/hash-table.cc
File be/src/exec/hash-table.cc:

http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/exec/hash-table.cc@1011
PS9, Line 1011:       llvm::PHINode* is_null_phi =
              :           builder.CreatePHI(codegen->bool_type(), 2, "is_null_phi");
              :       is_null_phi->addIncoming(codegen->true_value(), rwi.null_block());
              :       is_null_phi->addIncoming(codegen->false_value(), rwi.non_null_block());
Add IsNullAsNoolPhi?


http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/exprs/hive-udf-call.cc
File be/src/exprs/hive-udf-call.cc:

http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/exprs/hive-udf-call.cc@a295
PS9, Line 295: 
             : 
Have an a NullAsI8() functions?


http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/exprs/scalar-expr-evaluator.h
File be/src/exprs/scalar-expr-evaluator.h:

http://gerrit.cloudera.org:8080/#/c/18526/9/be/src/exprs/scalar-expr-evaluator.h@291
PS9, Line 291:   // Converts and stores 'val' to 'result_' according to its type. Intended to be called
             :   // from codegen code. 'byte_size' is only used for Decimals to determine what Decimal
             :   // type to use (Decimal4, Decimal8 or Decimal16). We don't take a 'ColumnType' object
             :   // because it would be difficult to construct it in codegen code.
Why is it difficult?



-- 
To view, visit http://gerrit.cloudera.org:8080/18526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6
Gerrit-Change-Number: 18526
Gerrit-PatchSet: 9
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 12:30:27 +0000
Gerrit-HasComments: Yes