You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/09 06:31:18 UTC

[GitHub] [arrow] ayushpranjal-dremio commented on a diff in pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

ayushpranjal-dremio commented on code in PR #10299:
URL: https://github.com/apache/arrow/pull/10299#discussion_r867669873


##########
cpp/src/gandiva/precompiled/time.cc:
##########
@@ -920,6 +920,202 @@ const char* castVARCHAR_timestamp_int64(gdv_int64 context, gdv_timestamp in,
   return ret;
 }
 

Review Comment:
   Can you add a short description of what this function is supposed to do?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org