You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/14 18:53:52 UTC
[GitHub] [airflow] potiuk opened a new pull request #22258: Optimize multiplatform builds
potiuk opened a new pull request #22258:
URL: https://github.com/apache/airflow/pull/22258
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22258:
URL: https://github.com/apache/airflow/pull/22258#issuecomment-1075633855
Anyone ? Cache refresh should be enabled soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22258:
URL: https://github.com/apache/airflow/pull/22258#issuecomment-1076334755
:D ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22258:
URL: https://github.com/apache/airflow/pull/22258#issuecomment-1074387267
Hey @ashb -> would love to merge this one as currently `main` is failing as I had to disable qemu support for our runners (to make sure that ARM engine will be used to build the images).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22258:
URL: https://github.com/apache/airflow/pull/22258#issuecomment-1073838947
This is an optimization (10x speedup) of building our mutliplatform images on CI as cache for other builds. I run it manually on my Macbook so far because of the time it took to build with emulation, but with this one the maximum total time of building the multiplatform images (both CI and PROD) on our CI is down to ~25 minutes from > 3 hours.
Completed, succesful run (I limited it and removed the regular tests there) can be found here: https://github.com/apache/airflow/runs/5626562720?check_suite_focus=true
With this approach we can actually even start thinking about running selected tests on ARM in "main" without actually spinning an ARM runner - that would be a nice step to follow but it is not implemented yet). Github Actions are also close to supporting ARM public runners it seems, so we can eventually get it running for both self-hosted and public runners.
I added several protections against spinnig up too many instances (including self-termination after 50 minutes) , but I will keep watching if we are not running too many of those once we merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #22258:
URL: https://github.com/apache/airflow/pull/22258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22258:
URL: https://github.com/apache/airflow/pull/22258#issuecomment-1079982004
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22258: Optimize Multiplatform cache builds
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22258:
URL: https://github.com/apache/airflow/pull/22258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org