You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apisix.apache.org by Abhishek Choudhary <sh...@apache.org> on 2024/07/23 04:07:47 UTC
[PROPOSAL]: Remove `core.grpc` module
Hi community,
Since APISIX no longer uses the `core.grpc` module, I propose we should
remove
it.
Here other reasons:
- It's usage in production is unstable and leads to crashes
- Removing Golang dependencies will make the builds easier and lean
This will be a breaking change for users who depend on the grpc module for
some
custom functionality. However, I strongly oppose including unstable
features in APISIX.
Regards,
Abhishek
APISIX Committer.
回复: [PROPOSAL]: Remove `core.grpc` module
Posted by 周杰雄 <zh...@foxmail.com>.
But how about the breaking change you mentioned?
"This will be a breaking change for users who depend on the grpc module for
some custom functionality"
------------------ 原始邮件 ------------------
发件人: "Abhishek Choudhary" <shreemaanabhishek@apache.org>;
发送时间: 2024年7月23日(星期二) 下午4:13
收件人: "周杰雄"<zhoujiexiong@foxmail.com>;
主题: Re: [PROPOSAL]: Remove `core.grpc` module
We got rid of the features in APISIX that used the `core.grpc` module.
Now this module is no longer in use by APISIX. That's why I proposed
to remove the `core.grpc` module.
> 1. at APISIX v3.x.x: try to fix the "unstable" issue;
There is nothing to be fixed in APISIX.
On Tue, 23 Jul 2024 at 12:14, 周杰雄 <zhoujiexiong@foxmail.com> wrote:
Hi shreemaanabhishek,
May be we could do like so:
1. at APISIX v3.x.x: try to fix the "unstable" issue;
2. in future, clear "core.grpc" at APISIX v4.x.x
Regards,
Billy
APISIX Contributor.
------------------ 原始邮件 ------------------
发件人: "dev" <shreemaanabhishek@apache.org>;
发送时间: 2024年7月23日(星期二) 中午12:07
收件人: "dev"<dev@apisix.apache.org>;
主题: [PROPOSAL]: Remove `core.grpc` module
Hi community,
Since APISIX no longer uses the `core.grpc` module, I propose we should
remove
it.
Here other reasons:
- It's usage in production is unstable and leads to crashes
- Removing Golang dependencies will make the builds easier and lean
This will be a breaking change for users who depend on the grpc module for
some
custom functionality. However, I strongly oppose including unstable
features in APISIX.
Regards,
Abhishek
APISIX Committer.
回复:[PROPOSAL]: Remove `core.grpc` module
Posted by 周杰雄 <zh...@foxmail.com>.
Hi shreemaanabhishek,
May be we could do like so:
1. at APISIX v3.x.x: try to fix the "unstable" issue;
2. in future, clear "core.grpc" at APISIX v4.x.x
Regards,
Billy
APISIX Contributor.
------------------ 原始邮件 ------------------
发件人: "dev" <shreemaanabhishek@apache.org>;
发送时间: 2024年7月23日(星期二) 中午12:07
收件人: "dev"<dev@apisix.apache.org>;
主题: [PROPOSAL]: Remove `core.grpc` module
Hi community,
Since APISIX no longer uses the `core.grpc` module, I propose we should
remove
it.
Here other reasons:
- It's usage in production is unstable and leads to crashes
- Removing Golang dependencies will make the builds easier and lean
This will be a breaking change for users who depend on the grpc module for
some
custom functionality. However, I strongly oppose including unstable
features in APISIX.
Regards,
Abhishek
APISIX Committer.
Re:[PROPOSAL]: Remove `core.grpc` module
Posted by kwanhur <hu...@163.com>.
For those custom functionality, any other friendly solution except eliminate including? <br/><br/>At least reserve some migration for it, example like use module `apisix.unstable.grpc` or others.
At 2024-07-23 12:07:47, "Abhishek Choudhary" <sh...@apache.org> wrote:
>Hi community,
>
>Since APISIX no longer uses the `core.grpc` module, I propose we should
>remove
>it.
>
>Here other reasons:
>- It's usage in production is unstable and leads to crashes
>- Removing Golang dependencies will make the builds easier and lean
>
>This will be a breaking change for users who depend on the grpc module for
>some
>custom functionality. However, I strongly oppose including unstable
>features in APISIX.
>
>Regards,
>Abhishek
>APISIX Committer.