You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "belugabehr (via GitHub)" <gi...@apache.org> on 2024/09/02 01:10:07 UTC
[PR] AVRO-4050: Deprecate MapUtil computeIfAbsent [avro]
belugabehr opened a new pull request, #3142:
URL: https://github.com/apache/avro/pull/3142
## What is the purpose of the change
* Make overall Avro package smaller and faster
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4050: Deprecate MapUtil computeIfAbsent [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #3142:
URL: https://github.com/apache/avro/pull/3142#discussion_r1749875701
##########
lang/java/avro/src/main/java/org/apache/avro/util/MapUtil.java:
##########
@@ -27,13 +27,13 @@ private MapUtil() {
}
/**
- * A temporary workaround for Java 8 specific performance issue JDK-8161372
- * .<br>
- * This class should be removed once we drop Java 8 support.
+ * A temporary workaround for Java 8 specific performance issue JDK-8161372.
*
* @see <a href=
* "https://bugs.openjdk.java.net/browse/JDK-8161372">JDK-8161372</a>
+ * @deprecated As of JDK 1.9 this issue has been resolved.
*/
+ @Deprecated
Review Comment:
```suggestion
// TODO: Remove for 1.13.0 or later
@Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4050: Deprecate MapUtil computeIfAbsent [avro]
Posted by "belugabehr (via GitHub)" <gi...@apache.org>.
belugabehr merged PR #3142:
URL: https://github.com/apache/avro/pull/3142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org