You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/05 09:39:44 UTC
[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request, #3903: Support windows generate `kyuubi-version-info.properties`
cxzl25 opened a new pull request, #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903
### _Why are the changes needed?_
#3847
Windows users need to generate `kyuubi-version-info.properties` to debug.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#issuecomment-1337213157
> Could you please test run test or debug in IDEA on Windows?
It can also run successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#issuecomment-1337259907
Thanks, merging to master/branch-1.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#issuecomment-1337183203
Great, run succeeded on windonws 10:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3903: Support windows generate `kyuubi-version-info.properties`
URL: https://github.com/apache/incubator-kyuubi/pull/3903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#issuecomment-1337185248
Could you please test run test or debug in IDEA on Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#issuecomment-1337258780
> Could you please test run test or debug in IDEA on Windows?
Debug
<img width="1219" alt="image" src="https://user-images.githubusercontent.com/3898450/205636754-f880453e-d578-4410-ab0b-b7a47249f646.png">
Some UTs that do not require `HADOOP_HOME` can run directly in IDEA
<img width="1219" alt="image" src="https://user-images.githubusercontent.com/3898450/205636811-c6e7f28a-e9ab-436f-bcfc-906f2767abfb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#discussion_r1039427252
##########
build/kyuubi-build-info.cmd:
##########
@@ -0,0 +1,50 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one or more
+rem contributor license agreements. See the NOTICE file distributed with
+rem this work for additional information regarding copyright ownership.
+rem The ASF licenses this file to You under the Apache License, Version 2.0
+rem (the "License"); you may not use this file except in compliance with
+rem the License. You may obtain a copy of the License at
+rem
+rem http://www.apache.org/licenses/LICENSE-2.0
+rem
+rem Unless required by applicable law or agreed to in writing, software
+rem distributed under the License is distributed on an "AS IS" BASIS,
+rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+rem See the License for the specific language governing permissions and
+rem limitations under the License.
+rem
+
+SET EXTRA_RESOURCE_DIR=%~1
+IF NOT EXIST "%EXTRA_RESOURCE_DIR%" MKDIR "%EXTRA_RESOURCE_DIR%"
+SET BUILD_INFO="%EXTRA_RESOURCE_DIR%"\kyuubi-version-info.properties
+CALL :echo_build_properties %* > "%BUILD_INFO%"
+
+EXIT /B %ERRORLEVEL%
+
+:echo_build_properties
+echo kyuubi_version=%~2
+echo kyuubi_java_version=%~3
+echo kyuubi_scala_version=%~4
+echo kyuubi_spark_version=%~5
+echo kyuubi_hive_version=%~6
+echo kyuubi_hadoop_version=%~7
+echo kyuubi_flink_version=%~8
+echo kyuubi_trino_version=%~9
+echo user=%username%
+
+FOR /F %%i IN ('git rev-parse HEAD') DO SET "revision=%%i"
+FOR /F %%i IN ('git rev-parse --abbrev-ref HEAD') DO SET "branch=%%i"
+FOR /F %%i IN ('git config --get remote.origin.url') DO SET "url=%%i"
+
+FOR /f %%i IN ('date /t') DO SET current_date=%%i
Review Comment:
The use of `date /t` under cmd needs to consider the locale, so the return value of `date /t` is not parsed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #3903: Support windows generate `kyuubi-version-info.properties`
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #3903:
URL: https://github.com/apache/incubator-kyuubi/pull/3903#discussion_r1039428425
##########
build/kyuubi-build-info.cmd:
##########
@@ -0,0 +1,50 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one or more
+rem contributor license agreements. See the NOTICE file distributed with
+rem this work for additional information regarding copyright ownership.
+rem The ASF licenses this file to You under the Apache License, Version 2.0
+rem (the "License"); you may not use this file except in compliance with
+rem the License. You may obtain a copy of the License at
+rem
+rem http://www.apache.org/licenses/LICENSE-2.0
+rem
+rem Unless required by applicable law or agreed to in writing, software
+rem distributed under the License is distributed on an "AS IS" BASIS,
+rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+rem See the License for the specific language governing permissions and
+rem limitations under the License.
+rem
+
+SET EXTRA_RESOURCE_DIR=%~1
+IF NOT EXIST "%EXTRA_RESOURCE_DIR%" MKDIR "%EXTRA_RESOURCE_DIR%"
+SET BUILD_INFO="%EXTRA_RESOURCE_DIR%"\kyuubi-version-info.properties
+CALL :echo_build_properties %* > "%BUILD_INFO%"
Review Comment:
windows
<img width="515" alt="image" src="https://user-images.githubusercontent.com/3898450/205617624-48c68ce2-5f53-4730-9a88-c610eb26f15e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org