You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ashangit (via GitHub)" <gi...@apache.org> on 2024/01/18 10:56:10 UTC
[PR] [FLINK-34131] Ensure cluster.health-check.checkpoint-progress.window is well configure [flink-kubernetes-operator]
ashangit opened a new pull request, #758:
URL: https://github.com/apache/flink-kubernetes-operator/pull/758
<!--
*Thank you very much for contributing to the Apache Flink Kubernetes Operator - we are happy that you want to help us improve the project. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix][docs] Fix typo in event time introduction` or `[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can read more on how we use GitHub Actions for CI [here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Add a check on the cluster.health-check.checkpoint-progress.window before to access if the cluster is healthy from checkpointing
cluster.health-check.checkpoint-progress.window must be greater than max(execution.checkpointing.interval * execution.checkpointing.tolerable-failed-checkpoints, execution.checkpointing.timeout * execution.checkpointing.tolerable-failed-checkpoints)
If it is below it can leads to unwanted restart of the flink cluster
## Brief change log
- *Ensure cluster.health-check.checkpoint-progress.window is well configure*
## Verifying this change
<!--
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
-->
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
- *Added unittest ensuring the checkpoint evalutaion is always true if the window value is not well configured*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34131] Ensure cluster.health-check.checkpoint-progress.window is well configure [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora merged PR #758:
URL: https://github.com/apache/flink-kubernetes-operator/pull/758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34131] Ensure cluster.health-check.checkpoint-progress.window is well configure [flink-kubernetes-operator]
Posted by "ashangit (via GitHub)" <gi...@apache.org>.
ashangit commented on code in PR #758:
URL: https://github.com/apache/flink-kubernetes-operator/pull/758#discussion_r1457417705
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/ClusterHealthEvaluator.java:
##########
@@ -174,6 +175,25 @@ private boolean evaluateCheckpoints(
return true;
}
+ var completedCheckpointsCheckWindow =
+ configuration.get(OPERATOR_CLUSTER_HEALTH_CHECK_CHECKPOINT_PROGRESS_WINDOW);
+
+ CheckpointConfig checkpointConfig = new CheckpointConfig();
+ checkpointConfig.configure(configuration);
+ var checkpointingInterval = checkpointConfig.getCheckpointInterval();
+ var checkpointingTimeout = checkpointConfig.getCheckpointTimeout();
+ var tolerationFailureNumber = checkpointConfig.getTolerableCheckpointFailureNumber() + 1;
+ if (completedCheckpointsCheckWindow.toMillis()
+ < Math.max(
+ checkpointingInterval * tolerationFailureNumber,
+ checkpointingTimeout * tolerationFailureNumber)) {
+ LOG.warn(
+ "cluster.health-check.checkpoint-progress.window is not long enough. "
+ + "It must be greater than max(execution.checkpointing.interval * execution.checkpointing.tolerable-failed-checkpoints, "
+ + "execution.checkpointing.timeout * execution.checkpointing.tolerable-failed-checkpoints)");
+ return true;
+ }
Review Comment:
Looks fine to me to default to appropriate value but I'm not sure to understand why defaulting to `2 * cpInterval` instead of `Math.max(checkpointingInterval * tolerationFailureNumber,checkpointingTimeout * tolerationFailureNumber)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34131] Ensure cluster.health-check.checkpoint-progress.window is well configure [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on code in PR #758:
URL: https://github.com/apache/flink-kubernetes-operator/pull/758#discussion_r1457436859
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/ClusterHealthEvaluator.java:
##########
@@ -174,6 +175,25 @@ private boolean evaluateCheckpoints(
return true;
}
+ var completedCheckpointsCheckWindow =
+ configuration.get(OPERATOR_CLUSTER_HEALTH_CHECK_CHECKPOINT_PROGRESS_WINDOW);
+
+ CheckpointConfig checkpointConfig = new CheckpointConfig();
+ checkpointConfig.configure(configuration);
+ var checkpointingInterval = checkpointConfig.getCheckpointInterval();
+ var checkpointingTimeout = checkpointConfig.getCheckpointTimeout();
+ var tolerationFailureNumber = checkpointConfig.getTolerableCheckpointFailureNumber() + 1;
+ if (completedCheckpointsCheckWindow.toMillis()
+ < Math.max(
+ checkpointingInterval * tolerationFailureNumber,
+ checkpointingTimeout * tolerationFailureNumber)) {
+ LOG.warn(
+ "cluster.health-check.checkpoint-progress.window is not long enough. "
+ + "It must be greater than max(execution.checkpointing.interval * execution.checkpointing.tolerable-failed-checkpoints, "
+ + "execution.checkpointing.timeout * execution.checkpointing.tolerable-failed-checkpoints)");
+ return true;
+ }
Review Comment:
What you write makes more sense I agree :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34131] Ensure cluster.health-check.checkpoint-progress.window is well configure [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on code in PR #758:
URL: https://github.com/apache/flink-kubernetes-operator/pull/758#discussion_r1457373687
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/ClusterHealthEvaluator.java:
##########
@@ -174,6 +175,25 @@ private boolean evaluateCheckpoints(
return true;
}
+ var completedCheckpointsCheckWindow =
+ configuration.get(OPERATOR_CLUSTER_HEALTH_CHECK_CHECKPOINT_PROGRESS_WINDOW);
+
+ CheckpointConfig checkpointConfig = new CheckpointConfig();
+ checkpointConfig.configure(configuration);
+ var checkpointingInterval = checkpointConfig.getCheckpointInterval();
+ var checkpointingTimeout = checkpointConfig.getCheckpointTimeout();
+ var tolerationFailureNumber = checkpointConfig.getTolerableCheckpointFailureNumber() + 1;
+ if (completedCheckpointsCheckWindow.toMillis()
+ < Math.max(
+ checkpointingInterval * tolerationFailureNumber,
+ checkpointingTimeout * tolerationFailureNumber)) {
+ LOG.warn(
+ "cluster.health-check.checkpoint-progress.window is not long enough. "
+ + "It must be greater than max(execution.checkpointing.interval * execution.checkpointing.tolerable-failed-checkpoints, "
+ + "execution.checkpointing.timeout * execution.checkpointing.tolerable-failed-checkpoints)");
+ return true;
+ }
Review Comment:
Instead if returning a warning and turning off a feature, would it make sense to default to `2 * cpInterval` ? That is probably more useful to the user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org