[GitHub] [beam] scwhittle commented on pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix

[GitBox <gi...@apache.org>]

scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-937828932


   I was unable to reproduce the error when I ran on my machine.
   I have not had time to investigate further.  Given that this isn't ready to
   merge I don't think it should be a blocker for the release.
   
   On Wed, Oct 6, 2021 at 8:33 PM Chamikara Jayalath ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
   > <https://github.com/apache/beam/pull/15416#discussion_r723575029>:
   >
   > > @@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
   >       */
   >      @Experimental(Kind.FILESYSTEM)
   >      public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
   > -      this(sink, StaticValueProvider.of(tempDirectory));
   > +      this(sink, StaticValueProvider.of(tempDirectory), false);
   >
   > Any updates ?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/15416#discussion_r723575029>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABBZZTDQXCI5NBVGDD3ZMXDUFSJABANCNFSM5DBQT3KA>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org