You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2023/04/12 18:10:50 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #7166: NIFI-11437 Improve EncryptContentPGP Content Type Detection

exceptionfactory opened a new pull request, #7166:
URL: https://github.com/apache/nifi/pull/7166

   # Summary
   
   [NIFI-11437](https://issues.apache.org/jira/browse/NIFI-11437) Improves content type detection in `EncryptContentPGP` using a [PushbackInputStream](https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html) to read up to 8 KB for initial evaluation.
   
   The new approach removes the separate call to `ProcessSession.read()` and instead uses a single initial buffer for content type detection.
   
   The runtime behavior change is observable in Processor statistics. For a 10 byte file created using `GenerateFlowFile`, the current version of `EncryptContentPGP` would show 20 bytes read. With these changes, `EncryptContentPGP` reports 10 bytes read because the buffered approach avoids multiple reads.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] greyp9 closed pull request #7166: NIFI-11437 Improve EncryptContentPGP Content Type Detection

Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 closed pull request #7166: NIFI-11437 Improve EncryptContentPGP Content Type Detection
URL: https://github.com/apache/nifi/pull/7166


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org