[GitHub] [lucene] iverase commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

["iverase (via GitHub)" <gi...@apache.org>]

iverase commented on code in PR #12380:
URL: https://github.com/apache/lucene/pull/12380#discussion_r1244728353


##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -749,6 +749,9 @@ protected void search(List<LeafReaderContext> leaves, Weight weight, Collector c
           partialResult = true;
         }
       }
+      // Note: this is called if collection ran successfully, including the above special cases of
+      // CollectionTerminatedException and TimeExceededException, but no other exception.
+      leafCollector.finish();

Review Comment:
   One thing I notice in the case there is no doc of interest, it won't be called (see `continue` statement), I wonder if we should call it even in that case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org