You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "martin-g (via GitHub)" <gi...@apache.org> on 2023/12/20 14:16:11 UTC
[PR] AVRO-3900: [Rust] Make it possible to use custom validators [avro]
martin-g opened a new pull request, #2643:
URL: https://github.com/apache/avro/pull/2643
AVRO-3900
WIP
TODO:
- Extract validators for enum symbols and record field names
- Polish the APIs
## What is the purpose of the change
* Make it possible the applications to configure custom validators for the schema name, namespace, enum symbols and record field names
## Verifying this change
* All new and old tests should pass!
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? RustDoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3900: [Rust] Make it possible to use custom names validators [avro]
Posted by "jslusher (via GitHub)" <gi...@apache.org>.
jslusher commented on PR #2643:
URL: https://github.com/apache/avro/pull/2643#issuecomment-1908567811
@martin-g Hi! @rodneykeeling is a colleague of mine who was kind enough to test this branch in a new Rust consumer he's making. If he says it works, then we're good to go. Thanks for putting this together!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3900: [Rust] Make it possible to use custom names validators [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2643:
URL: https://github.com/apache/avro/pull/2643#issuecomment-1907496888
I was waiting for a feedback from the reporter (@jslusher).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3900: [Rust] Make it possible to use custom names validators [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2643:
URL: https://github.com/apache/avro/pull/2643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3900: [Rust] Make it possible to use custom names validators [avro]
Posted by "rodneykeeling (via GitHub)" <gi...@apache.org>.
rodneykeeling commented on PR #2643:
URL: https://github.com/apache/avro/pull/2643#issuecomment-1906899024
This worked on my machine (both `SchemaNameValidator` and `SchemaNamespaceValidator` traits). Thanks for the work here! Is there anything else needed to get this merged (aside from merge conflict fixes)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3900: [Rust] Make it possible to use custom validators [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g closed pull request #2643: AVRO-3900: [Rust] Make it possible to use custom validators
URL: https://github.com/apache/avro/pull/2643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org