[GitHub] [maven-enforcer] bmhm commented on issue #58: [MENFORCER-288] Support new Java versioning schema for older versions.

[GitBox <gi...@apache.org>]

bmhm commented on issue #58: [MENFORCER-288] Support new Java versioning schema for older versions.
URL: https://github.com/apache/maven-enforcer/pull/58#issuecomment-565720039
 
 
   While I still not like the forced else, I added it as requested in other PRs. Note that this will make the commit much bigger, because there is need to re-indent a lot of code. If granted, I will happily change it to:
   
   ```java
           if ( PATTERN_MAIN_OLD_JDK.matcher( theJdkVersion ).matches() )
           {
               return "1." + theJdkVersion;
           }
   ```
   
   This would remove all those unnecessary changes:
   https://github.com/apache/maven-enforcer/pull/58/files#diff-e944db4bfa78de9044a8e0b7ff8f51c5R81-R112

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services