You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/10/05 01:04:47 UTC
[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #336: Fix
some issues with per-package custom commands
ccollins476ad opened a new pull request #336: Fix some issues with per-package custom commands
URL: https://github.com/apache/mynewt-newt/pull/336
This PR fixes a few issues that @andrzej-kaczmarek identified:
> 1. Scripts paths in packages should be relative to package root as otherwise it's impossible to create portable path.
> 2. Would be good if newt can define env for newt and toolchain binaries so scripts are more portable.
> 3. Seems like newt does not overwrite env if it is already set. This causes problem with recursive build and for now I just unset some env that I need in child build.
This PR also contains a change that was requested in the original PR, but which I mistakenly left out:
rename: `post_build` --> `post_link`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services