You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2014/10/13 21:33:34 UTC
[jira] [Created] (THRIFT-2785) Wrap errors in iostream_transport.go
Jens Geyer created THRIFT-2785:
----------------------------------
Summary: Wrap errors in iostream_transport.go
Key: THRIFT-2785
URL: https://issues.apache.org/jira/browse/THRIFT-2785
Project: Thrift
Issue Type: Improvement
Components: Go - Library
Reporter: Jens Geyer
Assignee: Jens Geyer
Priority: Minor
GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/246
Wrap errors in iostream_transport.go
When I used the StreamTransport to do unit tests I noticed that the EOF TTransportException is not correctly thrown. I quickly found out that the errors in iostream_transport.go where not wrapped with
NewTTransportExceptionFromError. Fixed that quickly and it works greatly!
Hope this saves others precious time when developing with thrift and go :-)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #246
----
commit c00fa154faa337db47a07c2c49d13d51c487d77a
Author: cvlchinet <cv...@chinet.info>
Date: 2014-10-11T22:57:23Z
Wrap errors in iostream_transport.go
Wrap errors in iostream_transport.go using NewTTransportExceptionFromError
----
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)