You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/28 17:52:08 UTC
[GitHub] [helix] narendly commented on a change in pull request #1718: Clarify error for ZkSessionMismatchedException in ZkAsyncCallbacks
narendly commented on a change in pull request #1718:
URL: https://github.com/apache/helix/pull/1718#discussion_r622410325
##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/callback/ZkAsyncCallbacks.java
##########
@@ -289,7 +290,11 @@ protected boolean needRetry(int rc) {
return false;
}
} catch (ClassCastException | NullPointerException ex) {
- LOG.error("Failed to handle unknown return code {}. Skip retrying.", rc, ex);
+ if(rc == ZK_SESSION_MISMATCHED_CODE) {
Review comment:
Nit: format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org