You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Justin Ross (Created) (JIRA)" <ji...@apache.org> on 2011/11/18 21:00:51 UTC
[jira] [Created] (QPID-3633) Make cmake the primary build tool for
the cpp tree
Make cmake the primary build tool for the cpp tree
--------------------------------------------------
Key: QPID-3633
URL: https://issues.apache.org/jira/browse/QPID-3633
Project: Qpid
Issue Type: Improvement
Components: Build Tools
Affects Versions: 0.15
Reporter: Justin Ross
Assignee: Andrew Stitcher
This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] [Created] (QPID-3633) Make cmake the primary build tool
for the cpp tree
Posted by "Darryl L. Pierce" <dp...@redhat.com>.
On Thu, Sep 20, 2012 at 05:36:59PM -0400, Andrew Stitcher wrote:
> On Thu, 2012-09-20 at 17:20 -0400, Darryl L. Pierce wrote:
> > ...
> > I opened a JIRA a while back that moved our build system to using Cmake.
> > It was assigned to Andrew, but I haven't seen anything done with it
> > since. I'd like this to get into the codebase so we can use it with the
> > 0.20 release and for packaging.
> >
> > Can I get a status, please?
>
> It's still slated for 0.20.
>
> Note that, these changes are mostly to do with the bindings and there
> other issues to finish before cmake can completely replace the autoconf
> tools - specifically to ensure that all the tests run the same, which
> they currently don't. Also to ensure that exactly the same files get
> installed in the correct places which these changes do address I think.
I've tested the changes using the Fedora package's expectations to
ensure that files are being installed into the correct locations. I'm
not sure what you mean about the patches being mostly about the
bindings, the changes are across the board for the Qpid codebase.
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
Re: [jira] [Created] (QPID-3633) Make cmake the primary build tool
for the cpp tree
Posted by Andrew Stitcher <as...@redhat.com>.
On Thu, 2012-09-20 at 17:20 -0400, Darryl L. Pierce wrote:
> ...
> I opened a JIRA a while back that moved our build system to using Cmake.
> It was assigned to Andrew, but I haven't seen anything done with it
> since. I'd like this to get into the codebase so we can use it with the
> 0.20 release and for packaging.
>
> Can I get a status, please?
It's still slated for 0.20.
Note that, these changes are mostly to do with the bindings and there
other issues to finish before cmake can completely replace the autoconf
tools - specifically to ensure that all the tests run the same, which
they currently don't. Also to ensure that exactly the same files get
installed in the correct places which these changes do address I think.
Andrew
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [jira] [Created] (QPID-3633) Make cmake the primary build tool
for the cpp tree
Posted by "Darryl L. Pierce" <dp...@redhat.com>.
On Fri, Nov 18, 2011 at 08:00:51PM +0000, Justin Ross (Created) (JIRA) wrote:
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.15
> Reporter: Justin Ross
> Assignee: Andrew Stitcher
>
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
I opened a JIRA a while back that moved our build system to using Cmake.
It was assigned to Andrew, but I haven't seen anything done with it
since. I'd like this to get into the codebase so we can use it with the
0.20 release and for packaging.
Can I get a status, please?
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
[jira] [Commented] (QPID-3633) Make cmake the primary build tool
for the cpp tree
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481224#comment-13481224 ]
Andrew Stitcher commented on QPID-3633:
---------------------------------------
committed changes r1400780-r1400783 which bring the cmake install target fairly closely into line with the automake install target.
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.19
> Reporter: Justin Ross
> Assignee: Andrew Stitcher
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-3633) Make cmake the primary build tool for
the cpp tree
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Pierce reassigned QPID-3633:
--------------------------------------
Assignee: Darryl L. Pierce (was: Andrew Stitcher)
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.15
> Reporter: Justin Ross
> Assignee: Darryl L. Pierce
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3633) Make cmake the primary build tool
for the cpp tree
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481463#comment-13481463 ]
Andrew Stitcher commented on QPID-3633:
---------------------------------------
This last issue has nothing really to do with this issue - it's just a different bug that has crept into the source base coincidentally at the same time.
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.19
> Reporter: Justin Ross
> Assignee: Andrew Stitcher
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3633) Make cmake the primary build tool
for the cpp tree
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481452#comment-13481452 ]
Darryl L. Pierce commented on QPID-3633:
----------------------------------------
In testing the updated Cmake setup, I hit a problem with the set_target_properties macro in amqp.make. Variables using in this macro need to be in double quotes to avoid the error:
CMake Error at src/amqp.cmake:75 (set_target_properties):
set_target_properties called with incorrect number of arguments.
The fix is:
diff --git a/qpid/cpp/src/amqp.cmake b/qpid/cpp/src/amqp.cmake
index 7a113a8..c8da3ab 100644
--- a/qpid/cpp/src/amqp.cmake
+++ b/qpid/cpp/src/amqp.cmake
@@ -74,8 +74,8 @@ if (BUILD_AMQP)
target_link_libraries (amqp qpidbroker qpidcommon)
set_target_properties (amqp PROPERTIES
PREFIX ""
- COMPILE_FLAGS ${PROTON_COMPILE_FLAGS}
- LINK_FLAGS ${PROTON_LINK_FLAGS})
+ COMPILE_FLAGS "${PROTON_COMPILE_FLAGS}"
+ LINK_FLAGS "${PROTON_LINK_FLAGS}")
install (TARGETS amqp
DESTINATION ${QPIDD_MODULE_DIR}
COMPONENT ${QPID_COMPONENT_BROKER})
@@ -109,8 +109,8 @@ if (BUILD_AMQP)
target_link_libraries (amqpc qpidclient qpidcommon)
set_target_properties (amqpc PROPERTIES
PREFIX ""
- COMPILE_FLAGS ${PROTON_COMPILE_FLAGS}
- LINK_FLAGS ${PROTON_LINK_FLAGS})
+ COMPILE_FLAGS "${PROTON_COMPILE_FLAGS}"
+ LINK_FLAGS "${PROTON_LINK_FLAGS}")
install (TARGETS amqpc
DESTINATION ${QPIDC_MODULE_DIR}
COMPONENT ${QPID_COMPONENT_CLIENT})
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.19
> Reporter: Justin Ross
> Assignee: Andrew Stitcher
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-3633) Make cmake the primary build
tool for the cpp tree
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481224#comment-13481224 ]
Andrew Stitcher edited comment on QPID-3633 at 10/22/12 6:59 AM:
-----------------------------------------------------------------
committed changes r1400780-r1400783 for 0.20 which bring the cmake install target fairly closely into line with the automake install target.
was (Author: astitcher):
committed changes r1400780-r1400783 which bring the cmake install target fairly closely into line with the automake install target.
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.19
> Reporter: Justin Ross
> Assignee: Andrew Stitcher
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-3633) Make cmake the primary build tool for
the cpp tree
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Pierce reassigned QPID-3633:
--------------------------------------
Assignee: Andrew Stitcher (was: Darryl L. Pierce)
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.19
> Reporter: Justin Ross
> Assignee: Andrew Stitcher
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-3633) Make cmake the primary build tool for
the cpp tree
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Pierce updated QPID-3633:
-----------------------------------
Affects Version/s: (was: 0.15)
0.19
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
> Key: QPID-3633
> URL: https://issues.apache.org/jira/browse/QPID-3633
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.19
> Reporter: Justin Ross
> Assignee: Darryl L. Pierce
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary (and very probably only) build tool for the cpp tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org