You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/20 09:42:59 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #21657: Add Release Profile for `distribution/proxy-native`
linghengqian opened a new pull request, #21657:
URL: https://github.com/apache/shardingsphere/pull/21657
For #21347.
Changes proposed in this pull request:
- Add Release Profile for `distribution/proxy-native`.
- Update GraalVM Native Build Tools to `0.9.16`.
- Add the corresponding LICENSE.
- Fixes the wrong Docker Base Image in the Dockerfile, because the current GraalVM Native Build Tools is still using dynamic linking instead of static linking, which requires more system library support.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#discussion_r1001322852
##########
distribution/proxy-native/pom.xml:
##########
@@ -67,6 +67,35 @@
</dependencies>
<profiles>
+ <profile>
+ <id>release</id>
Review Comment:
@strongduanmu I just want to make sure, does such a release note exist? 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#discussion_r1000404948
##########
distribution/proxy-native/pom.xml:
##########
@@ -67,6 +67,35 @@
</dependencies>
<profiles>
+ <profile>
+ <id>release</id>
Review Comment:
For this PR, if you need a binary package of release distribution/proxy-native, you need to execute `./mvnw -am -pl distribution/proxy-native -B -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true - Dspotless.apply.skip=true -Pnative,release clean package`. This requires both GraalVM CE for JDK 17 and the native-image component of GraalVM installed on the device on which this command is executed. In which document should I state this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#discussion_r1000404948
##########
distribution/proxy-native/pom.xml:
##########
@@ -67,6 +67,35 @@
</dependencies>
<profiles>
+ <profile>
+ <id>release</id>
Review Comment:
For this PR, if you need a binary package of release distribution/proxy-native, you need to execute `./mvnw -am -pl distribution/proxy-native -B -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true - Dspotless.apply.skip=true -Pnative,release clean package`. This requires both GraalVM CE 22.2.0 and the native-iamge component of GraalVM installed on the device on which this command is executed. In which document should I state this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#discussion_r1001385993
##########
distribution/proxy-native/pom.xml:
##########
@@ -67,6 +67,35 @@
</dependencies>
<profiles>
+ <profile>
+ <id>release</id>
Review Comment:
- I looked at the `Dockerfile` and release process of `distribution/proxy` and found that all the raw materials used to build the Docker Image are extracted from the `.tar.gz` file generated by the release profile.
- Is this an unwritten rule, or is it possible to make a Docker Image without making an intermediate `.tar.gz`? I'm not quite sure if `.tar.gz` is only needed for distributing binaries.
- If this provision exists, I will fix the `Dockerfile` of `distribution/proxy-native` when opening a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
linghengqian commented on PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#issuecomment-1285357710
- Do I have to copy and paste so much LICENSE content? Can I directly refer to the path where the `distribution/proxy`'s LICENSE is located for packaging? 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #21657: Add Release Profile for `distribution/proxy-native`
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#discussion_r1001362450
##########
distribution/proxy-native/pom.xml:
##########
@@ -67,6 +67,35 @@
</dependencies>
<profiles>
+ <profile>
+ <id>release</id>
Review Comment:
>
@linghengqian I think we can add this requirement in ShardingSphere release document——https://shardingsphere.apache.org/community/cn/involved/release/shardingsphere/#3-%E5%8F%91%E5%B8%83-docker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org