[GitHub] ocket8888 commented on a change in pull request #3299: Text roles

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3299: Text roles
URL: https://github.com/apache/trafficcontrol/pull/3299#discussion_r253629180
 
 

 ##########
 File path: traffic_control/clients/python/trafficops/tosession.py
 ##########
 @@ -1451,21 +1451,6 @@ def assign_delivery_services_to_federations(self, federation_id=None, data=None)
 		:raises: Union[LoginError, OperationError]
 		"""
 
-	@api_request(u'delete', u'federation_resolvers/{federation_id:d}/deliveryservices/'
 
 Review comment:
   Possibly, and I did consider changing it instead of removing it, but that appears to be removing a delivery service from a federation (which is in line with the method name) whereas the route in the method seems to be trying to remove it from a federation *resolver*. I don't really have a very good grasp on the difference, so I decided to just remove it rather than try to fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services