You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2023/07/05 11:08:40 UTC
[GitHub] [airflow] amoghrajesh commented on a diff in pull request #32368: Migrating Google AutoML example_dags to sys tests
amoghrajesh commented on code in PR #32368:
URL: https://github.com/apache/airflow/pull/32368#discussion_r1252944777
##########
tests/system/providers/google/cloud/automl/example_automl_nl_text_classification.py:
##########
@@ -35,17 +35,14 @@
AutoMLTrainModelOperator,
)
-GCP_PROJECT_ID = os.environ.get("GCP_PROJECT_ID", "your-project-id")
-GCP_AUTOML_LOCATION = os.environ.get("GCP_AUTOML_LOCATION", "us-central1")
-GCP_AUTOML_TEXT_CLS_BUCKET = os.environ.get("GCP_AUTOML_TEXT_CLS_BUCKET", "gs://INVALID BUCKET NAME")
-
-# Example values
-DATASET_ID = ""
+ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
+DAG_ID = "example_automl_classification"
+GCP_PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT", "default")
+GCP_AUTOML_LOCATION = "us-central1"
Review Comment:
I was following the convention of the other system tests written, for example in https://github.com/apache/airflow/pull/30003 and also in the automl folder. Does it make sense to auto hard code them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org