You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/08/11 01:48:57 UTC
Review Request: Allow resource changed callbacks in cgroups to be retried if
failed at the first time.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6534/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Introduced a general mechanism for resource changed callbacks to be retried if failed at the first time.
The main idea is to have a sequence number for each resource. A newer request will update the sequence number so that all the previous requests on that resource will be voided.
This elegantly solve the batching update problem!
This patch depends on
https://reviews.apache.org/r/6501/
Diffs
-----
src/slave/cgroups_isolation_module.hpp 00255b5
src/slave/cgroups_isolation_module.cpp 8a121e0
Diff: https://reviews.apache.org/r/6534/diff/
Testing
-------
make check.
Thanks,
Jie Yu
Re: Review Request: Allow resource changed callbacks in cgroups to be
retried if failed at the first time.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6534/
-----------------------------------------------------------
(Updated Aug. 13, 2012, 9:35 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Implemented a back off policy for retries. (Exponentially back off with factor 2.)
Also, make the "delay" function accept no more than 5 arguments (originally was 3).
Description
-------
Introduced a general mechanism for resource changed callbacks to be retried if failed at the first time.
The main idea is to have a sequence number for each resource. A newer request will update the sequence number so that all the previous requests on that resource will be voided.
This elegantly solve the batching update problem!
This patch depends on
https://reviews.apache.org/r/6501/
Diffs (updated)
-----
src/slave/cgroups_isolation_module.hpp 00255b5
src/slave/cgroups_isolation_module.cpp 8a121e0
third_party/libprocess/include/process/delay.hpp f9f2c5e
Diff: https://reviews.apache.org/r/6534/diff/
Testing
-------
make check.
Thanks,
Jie Yu