You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/28 21:21:58 UTC
[GitHub] [superset] iercan opened a new issue #18220: Save as dashboard with duplicating chats is not working after 1.4.0 upgrade
iercan opened a new issue #18220:
URL: https://github.com/apache/superset/issues/18220
After upgrading to 1.4.0 we are not able to save as a dashboard with duplicate chart option. This is the error shown in the logs. It gives the same error on all dashboards I tried.
> superset_1 | 'NoneType' object has no attribute 'roles'
superset_1 | Traceback (most recent call last):
superset_1 | File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
superset_1 | rv = self.dispatch_request()
superset_1 | File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
superset_1 | return self.view_functions[rule.endpoint](**req.view_args)
superset_1 | File "/usr/local/lib/python3.8/site-packages/flask_appbuilder/security/decorators.py", line 148, in wraps
superset_1 | return f(self, *args, **kwargs)
superset_1 | File "/app/superset/utils/log.py", line 240, in wrapper
superset_1 | value = f(*args, add_extra_log_payload=log, **kwargs)
superset_1 | File "/app/superset/utils/decorators.py", line 104, in wrapper
superset_1 | raise exception
superset_1 | File "/app/superset/utils/decorators.py", line 100, in wrapper
superset_1 | current_app.appbuilder.sm.raise_for_dashboard_access(dashboard)
superset_1 | File "/app/superset/security/manager.py", line 1180, in raise_for_dashboard_access
superset_1 | for dashboard_role in dashboard.roles
superset_1 | AttributeError: 'NoneType' object has no attribute 'roles'
superset_1 | 2022-01-28 21:10:43,139:ERROR:superset.views.base:'NoneType' object has no attribute 'roles'
superset_1 | Traceback (most recent call last):
superset_1 | File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
superset_1 | rv = self.dispatch_request()
superset_1 | File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
superset_1 | return self.view_functions[rule.endpoint](**req.view_args)
superset_1 | File "/usr/local/lib/python3.8/site-packages/flask_appbuilder/security/decorators.py", line 148, in wraps
superset_1 | return f(self, *args, **kwargs)
superset_1 | File "/app/superset/utils/log.py", line 240, in wrapper
superset_1 | value = f(*args, add_extra_log_payload=log, **kwargs)
superset_1 | File "/app/superset/utils/decorators.py", line 104, in wrapper
superset_1 | raise exception
superset_1 | File "/app/superset/utils/decorators.py", line 100, in wrapper
superset_1 | current_app.appbuilder.sm.raise_for_dashboard_access(dashboard)
superset_1 | File "/app/superset/security/manager.py", line 1180, in raise_for_dashboard_access
superset_1 | for dashboard_role in dashboard.roles
superset_1 | AttributeError: 'NoneType' object has no attribute 'roles'
#### How to reproduce the bug
1. Open a dashboard
2. Click save as option
3. Choose duplicate charts and save
### Expected results
New dashboard should be created by duplicating charts
### Actual results
Process fails
### Environment
(please complete the following information):
- browser type and version: chrome 97
- superset version: 1.4.0 deployed with official image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1027115603
We don't have dashboard_rbac enabled and still have the issue on v. 1.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1027235203
If @geido cannot reproduce on master, it seems that there might a solution that could be cherry-picked from it?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1026566294
Confirming this for our deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1027094220
@geido Can you try it with dashboard_rbac feature flag enabled. I suspect it is related with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1027233809
I just tested it with 1.4.0 Docker image with all FEATURE_FLAGS unaltered, i.e., with only the defalut feature flags activated:
The issue is still present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1026640178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1038759317
I've tested it on 1.4.1. Problem seems resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan closed issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
iercan closed issue #18220:
URL: https://github.com/apache/superset/issues/18220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #18220: Save as dashboard with duplicating charts is not working after 1.4.0 upgrade
Posted by GitBox <gi...@apache.org>.
geido commented on issue #18220:
URL: https://github.com/apache/superset/issues/18220#issuecomment-1027088271
I cannot reproduce on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org