[GitHub] [superset] rusackas commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r779998412



##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
 import React from 'react';
 import { mount, shallow } from 'enzyme';
 import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';

Review comment:
       Think it's worth the trouble to `export` this from `@superset-ui/core` so that we can just do:
   `import { promiseTimeout, WithLegend } from '@superset-ui/core';`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org