You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2016/08/12 10:54:10 UTC
[GitHub] flink pull request #2362: [FLINK-4385] [table] Union on Timestamp fields doe...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2362
[FLINK-4385] [table] Union on Timestamp fields does not work
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [X] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR fix the problem mentioned in JIRA. The reason is that it will call `estimateRowSize` and encounter type mismatch for temporal types in batch mode.
Another fix is the IntervalTypeInfo's Comparator instantiation, the constructor of TypeComparator should be `boolean`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink FLINK-4385
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2362
----
commit dc2026e0a1034d947dc9f5b3a7eec5286d4429c0
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2016-08-12T09:48:23Z
[FLINK-4385] [table] Union on Timestamp fields does not work
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2362: [FLINK-4385] [table] Union on Timestamp fields doe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2362: [FLINK-4385] [table] Union on Timestamp fields does not w...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2362
@wuchong Thanks for the fix! Will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---