You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/21 14:26:52 UTC
[GitHub] [shardingsphere] Liangda-w opened a new pull request #11936: Parse function segment
Liangda-w opened a new pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936
Relates #10513
Changes proposed in this pull request:
- Parse function segment
- Add corresponding test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on a change in pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#discussion_r693469115
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleDDLStatementSQLVisitor.java
##########
@@ -425,6 +425,9 @@ public ASTNode visitAssociateStatistics(final AssociateStatisticsContext ctx) {
for (IndexNameContext each: ctx.functionAssociation().indexName()) {
result.getIndexes().add((IndexSegment) visit(each));
}
+// for (FunctionContext each: ctx.functionAssociation().function()) {
+// result.getFunctions().add((FunctionSegment) visit(each));
+// }
Review comment:
Thanks for your suggestion. I've tried it, but it gives the same error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#discussion_r694438804
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleDDLStatementSQLVisitor.java
##########
@@ -425,6 +425,9 @@ public ASTNode visitAssociateStatistics(final AssociateStatisticsContext ctx) {
for (IndexNameContext each: ctx.functionAssociation().indexName()) {
result.getIndexes().add((IndexSegment) visit(each));
}
+// for (FunctionContext each: ctx.functionAssociation().function()) {
+// result.getFunctions().add((FunctionSegment) visit(each));
+// }
Review comment:
Because, you miss a visit function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#issuecomment-903131023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11936](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a705dbe) into [master](https://codecov.io/gh/apache/shardingsphere/commit/679b0e51b2957cd9d7bf503de67ce11fbabb844a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (679b0e5) will **decrease** coverage by `0.07%`.
> The diff coverage is `10.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
============================================
- Coverage 63.04% 62.96% -0.08%
- Complexity 1229 1230 +1
============================================
Files 2300 2303 +3
Lines 34842 34840 -2
Branches 6052 6051 -1
============================================
- Hits 21965 21938 -27
- Misses 11100 11127 +27
+ Partials 1777 1775 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/statement/impl/OracleDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `85.50% <ø> (ø)` | |
| [...l/common/segment/ddl/function/FunctionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZGRsL2Z1bmN0aW9uL0Z1bmN0aW9uU2VnbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...oracle/ddl/OracleAssociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVBc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cle/ddl/OracleDisassociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVEaXNhc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rized/asserts/segment/function/FunctionAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Z1bmN0aW9uL0Z1bmN0aW9uQXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/ddl/impl/AssociateStatisticsStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGRsL2ltcGwvQXNzb2NpYXRlU3RhdGlzdGljc1N0YXRlbWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dl/impl/DisassociateStatisticsStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGRsL2ltcGwvRGlzYXNzb2NpYXRlU3RhdGlzdGljc1N0YXRlbWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...domain/segment/impl/function/ExpectedFunction.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Z1bmN0aW9uL0V4cGVjdGVkRnVuY3Rpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ment/ddl/AssociateStatisticsStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2RkbC9Bc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50VGVzdENhc2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...t/ddl/DisassociateStatisticsStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2RkbC9EaXNhc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50VGVzdENhc2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [679b0e5...a705dbe](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#issuecomment-903131023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11936](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab295e2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/679b0e51b2957cd9d7bf503de67ce11fbabb844a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (679b0e5) will **increase** coverage by `0.05%`.
> The diff coverage is `26.31%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
============================================
+ Coverage 63.04% 63.09% +0.05%
- Complexity 1229 1236 +7
============================================
Files 2300 2296 -4
Lines 34842 34907 +65
Branches 6052 6069 +17
============================================
+ Hits 21965 22025 +60
- Misses 11100 11101 +1
- Partials 1777 1781 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/common/segment/ddl/function/FunctionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZGRsL2Z1bmN0aW9uL0Z1bmN0aW9uU2VnbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...oracle/ddl/OracleAssociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVBc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cle/ddl/OracleDisassociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVEaXNhc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rized/asserts/segment/function/FunctionAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Z1bmN0aW9uL0Z1bmN0aW9uQXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/ddl/impl/AssociateStatisticsStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGRsL2ltcGwvQXNzb2NpYXRlU3RhdGlzdGljc1N0YXRlbWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dl/impl/DisassociateStatisticsStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGRsL2ltcGwvRGlzYXNzb2NpYXRlU3RhdGlzdGljc1N0YXRlbWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...r/statement/impl/OracleDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `85.51% <85.71%> (+<0.01%)` | :arrow_up: |
| [...itor/statement/impl/OracleStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.27% <100.00%> (+0.12%)` | :arrow_up: |
| [...domain/segment/impl/function/ExpectedFunction.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Z1bmN0aW9uL0V4cGVjdGVkRnVuY3Rpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ment/ddl/AssociateStatisticsStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2RkbC9Bc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50VGVzdENhc2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| ... and [83 more](https://codecov.io/gh/apache/shardingsphere/pull/11936/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [679b0e5...ab295e2](https://codecov.io/gh/apache/shardingsphere/pull/11936?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#discussion_r693425408
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleDDLStatementSQLVisitor.java
##########
@@ -425,6 +425,9 @@ public ASTNode visitAssociateStatistics(final AssociateStatisticsContext ctx) {
for (IndexNameContext each: ctx.functionAssociation().indexName()) {
result.getIndexes().add((IndexSegment) visit(each));
}
+// for (FunctionContext each: ctx.functionAssociation().function()) {
+// result.getFunctions().add((FunctionSegment) visit(each));
+// }
Review comment:
Maybe could invalidate caches in IntelliJ and maven clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#issuecomment-904312471
@Liangda-w Got it. @wgy8283335 Please review one more time here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#issuecomment-903698377
@Liangda-w I suppose you have received the reminder from GSoC committee about the final evaluation. If you need my help, please let me know. That's our last phase, let us stick it through. @Liangda-w @wgy8283335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 merged pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
wgy8283335 merged pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#issuecomment-904088763
> @Liangda-w I suppose you have received the reminder from GSoC committee about the final evaluation. If you need my help, please let me know. That's our last phase, let us stick it through. @Liangda-w @wgy8283335
Thanks @tristaZero, I've already submitted my final evaluation:) Please let me know in case of any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#issuecomment-906277171
@wgy8283335 Thanks, please add proper labels for each PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on a change in pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#discussion_r694587847
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleDDLStatementSQLVisitor.java
##########
@@ -425,6 +425,9 @@ public ASTNode visitAssociateStatistics(final AssociateStatisticsContext ctx) {
for (IndexNameContext each: ctx.functionAssociation().indexName()) {
result.getIndexes().add((IndexSegment) visit(each));
}
+// for (FunctionContext each: ctx.functionAssociation().function()) {
+// result.getFunctions().add((FunctionSegment) visit(each));
+// }
Review comment:
Oh yes, thank you!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #11936: Parse function segment
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on a change in pull request #11936:
URL: https://github.com/apache/shardingsphere/pull/11936#discussion_r693361341
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleDDLStatementSQLVisitor.java
##########
@@ -425,6 +425,9 @@ public ASTNode visitAssociateStatistics(final AssociateStatisticsContext ctx) {
for (IndexNameContext each: ctx.functionAssociation().indexName()) {
result.getIndexes().add((IndexSegment) visit(each));
}
+// for (FunctionContext each: ctx.functionAssociation().function()) {
+// result.getFunctions().add((FunctionSegment) visit(each));
+// }
Review comment:
Hi @wgy8283335, I tried to parse `function` segment in a similar with as `index` segment. However, with these commented line above I'm getting this error
```
java.lang.ClassCastException: org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue cannot be cast to org.apache.shardingsphere.sql.parser.sql.common.segment.ddl.function.FunctionSegment
```
Do you have idea how to resolve this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org