[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3030: do not read 1-past-size

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3030:
URL: https://github.com/apache/arrow-rs/pull/3030#discussion_r1014882986


##########
parquet/src/encodings/rle.rs:
##########
@@ -476,7 +476,7 @@ impl RleDecoder {
                 let mut num_values =
                     cmp::min(max_values - values_read, self.bit_packed_left as usize);
 
-                num_values = cmp::min(num_values, index_buf.len());
+                num_values = cmp::min(num_values, index_buf.len() - 1);

Review Comment:
   So this is not correct as `num_values` is the number of values to read and not the maximum numeric value.
   
   I suspect this is a similar issue to #1458



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org