You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/01/26 03:37:08 UTC

[mp2] loading modules for testing

With the current cvs mod_perl 2.0, I get a problem about
deciding which modules to load from the installed httpd.conf.
This patch

=============================================================
Index: Apache-Test/lib/Apache/TestConfigParse.pm
===================================================================
RCS file: /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm,v
retrieving revision 1.28
diff -u -r1.28 TestConfigParse.pm
--- Apache-Test/lib/Apache/TestConfigParse.pm	23 Jan 2003 04:06:38 -0000	1.28
+++ Apache-Test/lib/Apache/TestConfigParse.pm	26 Jan 2003 02:33:42 -0000
@@ -86,7 +86,7 @@
 
 #XXX mod_jk requires JkWorkerFile or JkWorker to be configured
 #skip it for now, tomcat has its own test suite anyhow.
-my %skip_modules = map { $_, 1 } qw(mod_jk.c);
+my %skip_modules = map { $_, 1 } qw(mod_jk.c mod_perl.c);
 
 # add modules to be not inherited from the existing config.
 # e.g. prevent from LoadModule perl_module to be included twice, when
@@ -121,7 +121,7 @@
 
         $name = $modname_alias{$name} if $modname_alias{$name};
 
-        unless ($self->should_skip_module($name)) {
+        if ($self->should_skip_module($name)) {
             debug "Skipping LoadModule of $name";
             next;
         }
=================================================================

The s/unless/if/ I think is just a typo? The other one
about adding mod_perl.c to %skip_modules I'm not sure -
it appears to be handled from config_parse_skip_module_add,
but without the above patch the installed mod_perl.so is
used, rather than the one just built in the sources.

-- 
best regards,
randy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] loading modules for testing

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 26 Jan 2003, Stas Bekman wrote:

> Randy Kobes wrote:
> > With the current cvs mod_perl 2.0, I get a problem about
> > deciding which modules to load from the installed httpd.conf.
> > This patch
> 
> Thanks Randy for pointing this out. I was trying to resolve the
> same bug for t/conf/httpd.conf created in sub-dirs, but broke
> it for the main server.  Please try again with the current cvs,
> it should work.

Thanks, Stas - it works fine now ... 

-- 
best regards,
randy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] loading modules for testing

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> With the current cvs mod_perl 2.0, I get a problem about
> deciding which modules to load from the installed httpd.conf.
> This patch

Thanks Randy for pointing this out. I was trying to resolve the same bug for 
t/conf/httpd.conf created in sub-dirs, but broke it for the main server. 
Please try again with the current cvs, it should work.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org