You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (Resolved) (JIRA)" <ji...@apache.org> on 2011/11/04 21:47:51 UTC
[jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
[ https://issues.apache.org/jira/browse/SLING-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-2265.
-----------------------------------
Resolution: Fixed
done in r1197759 with a demo addition to the test-bundles project in r1197760
> maven-launchpad-plugin should support a syntax similar to the maven-dependency-plugin
> -------------------------------------------------------------------------------------
>
> Key: SLING-2265
> URL: https://issues.apache.org/jira/browse/SLING-2265
> Project: Sling
> Issue Type: Improvement
> Components: Maven Plugins and Archetypes
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Maven Launchpad Plugin 2.1.2
>
>
> Something like:
> <configuration>
> <includeDependencies>
> <startLevel>
> <level>1</level>
> <includeArtifactIds>
> org.apache.sling.servlets.compat
> </includeArtifactIds>
> </startLevel>
> </includeDependencies>
> </configuration>
> This should take precendence over the mechanism created in SLING-2194
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Tobias Bocanegra <tr...@adobe.com>.
On Sat, Nov 5, 2011 at 3:03 AM, Carsten Ziegeler <cz...@apache.org> wrote:
> Hi,
>
> I really appreciate the work spent in this stuff - but how many
> different ways do we now have to configure the bundle list? And none
> of them is really satisfying I think. Still the best approach we have
> right now from a configuration point of view is imho the separate xml
> file.
as i said before, it's error prone and not supported by IDEs.
> The best way would be to annotate dependencies in the pom directly
> with their start level - which is - according to the maven guys - not
> possible atm.
> But we really want to go this way, I think this is possible, e.g. we
> could define an xml namespace we use in the pom and then just do:
> <dependency sling:startLevel="1">
that would be great.
> so we annotate the dependency element with our own attribute in our
> namespace. Maven does not complain about this. We could then just read
> the pom file ourselves to parse the annotations or use xslt to convert
> it to a bundle list or any other clever way.
>
> If others think that this way would be much better than the other ways
> we now have, I'm happy to implement it.
+1 sounds good to me
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Carsten Ziegeler <cz...@apache.org>.
Hi,
I agree somehow and disagree at the same time :) So far, we have
different options but none of them is optimal, this has a direct
impact on the user. With the suggested workaround we have the optimal
solution for the user and its our task to keep it running with newer
maven versions - if this is ever going to change in maven. I'll
contact the maven list once more to find out what they think about it.
Carsten
2011/11/6 Justin Edelson <ju...@justinedelson.com>:
> Hi Carsten,
>
> On Sat, Nov 5, 2011 at 9:20 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> 2011/11/5 Jukka Zitting <ju...@gmail.com>:
>>> Hi,
>>>
>>> On Sun, Nov 6, 2011 at 12:11 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>>>> Yes, but the tooling point only applies partially - there is no
>>>> tooling for the various plugin configurations including the new
>>>> configuration for this plugin. So there is no tooling support for that
>>>> regardless which way we go.
>>>
>>> At least Eclipse with m2e will automatically introspect plugins to
>>> find out what configuration options they support. With that
>>> information I have automatic validation, code completion and
>>> context-sensitive documentation for plugin configuration. That's
>>> obviously not a killer feature, but still nice to have. As a user of
>>> the plugin I'd rather live with a bit more verbose and less coherent
>>> POM file than lose this and other features like inheritance or
>>> profiles.
>>
>> Sure, so far I haven't seen a use case for inheritance and profiles
>> when it comes to bundle lists - which of course doesn't mean that they
>> don't exist.
>>
>> But what I've seen is typos and all kind of maintenance problems if
>> the information has to be maintained at more than one place. Before
>> the bundle list we used an internal way which is pretty similar to
>> this new one and all types of user errors occured. :)
>
> While I appreciate your concern about this, I don't think it is
> actually true of the latest SLING-2194/SLING-2265 changes. If you use
> both mechanisms, then *all* of your dependencies are placed into the
> bundle list at some default level and you only need to call out the
> artifactIds for the cases where you want a non-default bundle level.
> This means less maintenance and errors along the way, at least I hope
> that's the case.
>
> I do agree with you that the ultimate solution is to have
> dependency-level metadata in the pom. But I'd rather see that problem
> solved in Maven itself (or see us move away from Maven) instead of
> having some potentially non-forward compatible solution.
>
> Justin
>
>>
>> Regards
>> Carsten
>>
>>> BR,
>>>
>>> Jukka Zitting
>>>
>>
>>
>>
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>>
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Justin Edelson <ju...@justinedelson.com>.
Hi Carsten,
On Sat, Nov 5, 2011 at 9:20 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> 2011/11/5 Jukka Zitting <ju...@gmail.com>:
>> Hi,
>>
>> On Sun, Nov 6, 2011 at 12:11 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>>> Yes, but the tooling point only applies partially - there is no
>>> tooling for the various plugin configurations including the new
>>> configuration for this plugin. So there is no tooling support for that
>>> regardless which way we go.
>>
>> At least Eclipse with m2e will automatically introspect plugins to
>> find out what configuration options they support. With that
>> information I have automatic validation, code completion and
>> context-sensitive documentation for plugin configuration. That's
>> obviously not a killer feature, but still nice to have. As a user of
>> the plugin I'd rather live with a bit more verbose and less coherent
>> POM file than lose this and other features like inheritance or
>> profiles.
>
> Sure, so far I haven't seen a use case for inheritance and profiles
> when it comes to bundle lists - which of course doesn't mean that they
> don't exist.
>
> But what I've seen is typos and all kind of maintenance problems if
> the information has to be maintained at more than one place. Before
> the bundle list we used an internal way which is pretty similar to
> this new one and all types of user errors occured. :)
While I appreciate your concern about this, I don't think it is
actually true of the latest SLING-2194/SLING-2265 changes. If you use
both mechanisms, then *all* of your dependencies are placed into the
bundle list at some default level and you only need to call out the
artifactIds for the cases where you want a non-default bundle level.
This means less maintenance and errors along the way, at least I hope
that's the case.
I do agree with you that the ultimate solution is to have
dependency-level metadata in the pom. But I'd rather see that problem
solved in Maven itself (or see us move away from Maven) instead of
having some potentially non-forward compatible solution.
Justin
>
> Regards
> Carsten
>
>> BR,
>>
>> Jukka Zitting
>>
>
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Carsten Ziegeler <cz...@apache.org>.
Just had a second thought on this :) I think we can forget about
supporting pom inheritance for bundle lists. We have the partial
bundle lists for this. This leaves us with profiles which should be
easy to support.
Regards
Carsten
2011/11/5 Carsten Ziegeler <cz...@apache.org>:
> 2011/11/5 Jukka Zitting <ju...@gmail.com>:
>> Hi,
>>
>> On Sun, Nov 6, 2011 at 12:11 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>>> Yes, but the tooling point only applies partially - there is no
>>> tooling for the various plugin configurations including the new
>>> configuration for this plugin. So there is no tooling support for that
>>> regardless which way we go.
>>
>> At least Eclipse with m2e will automatically introspect plugins to
>> find out what configuration options they support. With that
>> information I have automatic validation, code completion and
>> context-sensitive documentation for plugin configuration. That's
>> obviously not a killer feature, but still nice to have. As a user of
>> the plugin I'd rather live with a bit more verbose and less coherent
>> POM file than lose this and other features like inheritance or
>> profiles.
>
> Sure, so far I haven't seen a use case for inheritance and profiles
> when it comes to bundle lists - which of course doesn't mean that they
> don't exist.
>
> But what I've seen is typos and all kind of maintenance problems if
> the information has to be maintained at more than one place. Before
> the bundle list we used an internal way which is pretty similar to
> this new one and all types of user errors occured. :)
>
> Regards
> Carsten
>
>> BR,
>>
>> Jukka Zitting
>>
>
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Carsten Ziegeler <cz...@apache.org>.
2011/11/5 Jukka Zitting <ju...@gmail.com>:
> Hi,
>
> On Sun, Nov 6, 2011 at 12:11 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>> Yes, but the tooling point only applies partially - there is no
>> tooling for the various plugin configurations including the new
>> configuration for this plugin. So there is no tooling support for that
>> regardless which way we go.
>
> At least Eclipse with m2e will automatically introspect plugins to
> find out what configuration options they support. With that
> information I have automatic validation, code completion and
> context-sensitive documentation for plugin configuration. That's
> obviously not a killer feature, but still nice to have. As a user of
> the plugin I'd rather live with a bit more verbose and less coherent
> POM file than lose this and other features like inheritance or
> profiles.
Sure, so far I haven't seen a use case for inheritance and profiles
when it comes to bundle lists - which of course doesn't mean that they
don't exist.
But what I've seen is typos and all kind of maintenance problems if
the information has to be maintained at more than one place. Before
the bundle list we used an internal way which is pretty similar to
this new one and all types of user errors occured. :)
Regards
Carsten
> BR,
>
> Jukka Zitting
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Sun, Nov 6, 2011 at 12:11 AM, Carsten Ziegeler <cz...@apache.org> wrote:
> Yes, but the tooling point only applies partially - there is no
> tooling for the various plugin configurations including the new
> configuration for this plugin. So there is no tooling support for that
> regardless which way we go.
At least Eclipse with m2e will automatically introspect plugins to
find out what configuration options they support. With that
information I have automatic validation, code completion and
context-sensitive documentation for plugin configuration. That's
obviously not a killer feature, but still nice to have. As a user of
the plugin I'd rather live with a bit more verbose and less coherent
POM file than lose this and other features like inheritance or
profiles.
BR,
Jukka Zitting
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Carsten Ziegeler <cz...@apache.org>.
Yes, but the tooling point only applies partially - there is no
tooling for the various plugin configurations including the new
configuration for this plugin. So there is no tooling support for that
regardless which way we go.
I agree for inheritance and profiles...however I think we could go
without them for the most use cases. In any way I'll try to talk to
some Maven guys during the ApacheCon.
Regards
Carsten
2011/11/5 Jukka Zitting <ju...@gmail.com>:
> Hi,
>
> On Sat, Nov 5, 2011 at 3:03 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>> [...] just read the pom file ourselves to parse the annotations [...]
>
> What about POM inheritance and profiles? Or stuff like polyglot POMs?
>
> Sticking with standard Maven dependencies and the normal plugin
> configuration mechanism is IMHO a much more failsafe and future-proof
> approach. It also works well with IDEs and other tools that understand
> Maven.
>
> BR,
>
> Jukka Zitting
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Sat, Nov 5, 2011 at 3:03 AM, Carsten Ziegeler <cz...@apache.org> wrote:
> [...] just read the pom file ourselves to parse the annotations [...]
What about POM inheritance and profiles? Or stuff like polyglot POMs?
Sticking with standard Maven dependencies and the normal plugin
configuration mechanism is IMHO a much more failsafe and future-proof
approach. It also works well with IDEs and other tools that understand
Maven.
BR,
Jukka Zitting
Re: [jira] [Resolved] (SLING-2265) maven-launchpad-plugin should
support a syntax similar to the maven-dependency-plugin
Posted by Carsten Ziegeler <cz...@apache.org>.
Hi,
I really appreciate the work spent in this stuff - but how many
different ways do we now have to configure the bundle list? And none
of them is really satisfying I think. Still the best approach we have
right now from a configuration point of view is imho the separate xml
file.
The best way would be to annotate dependencies in the pom directly
with their start level - which is - according to the maven guys - not
possible atm.
But we really want to go this way, I think this is possible, e.g. we
could define an xml namespace we use in the pom and then just do:
<dependency sling:startLevel="1">
so we annotate the dependency element with our own attribute in our
namespace. Maven does not complain about this. We could then just read
the pom file ourselves to parse the annotations or use xslt to convert
it to a bundle list or any other clever way.
If others think that this way would be much better than the other ways
we now have, I'm happy to implement it.
WDYT?
Regards
Carsten
2011/11/4 Justin Edelson (Resolved) (JIRA) <ji...@apache.org>:
>
> [ https://issues.apache.org/jira/browse/SLING-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Justin Edelson resolved SLING-2265.
> -----------------------------------
>
> Resolution: Fixed
>
> done in r1197759 with a demo addition to the test-bundles project in r1197760
>
>> maven-launchpad-plugin should support a syntax similar to the maven-dependency-plugin
>> -------------------------------------------------------------------------------------
>>
>> Key: SLING-2265
>> URL: https://issues.apache.org/jira/browse/SLING-2265
>> Project: Sling
>> Issue Type: Improvement
>> Components: Maven Plugins and Archetypes
>> Reporter: Justin Edelson
>> Assignee: Justin Edelson
>> Fix For: Maven Launchpad Plugin 2.1.2
>>
>>
>> Something like:
>> <configuration>
>> <includeDependencies>
>> <startLevel>
>> <level>1</level>
>> <includeArtifactIds>
>> org.apache.sling.servlets.compat
>> </includeArtifactIds>
>> </startLevel>
>> </includeDependencies>
>> </configuration>
>> This should take precendence over the mechanism created in SLING-2194
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Carsten Ziegeler
cziegeler@apache.org