[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #163:
URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r746622662



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1300,27 +1299,29 @@ public void endElement(String uri, String localName, String qName) throws SAXExc
         }
     }
 
-    private int getNumChildrenWithType(Node parent, Node child) throws RepositoryException {
-
-        int count=0;
-       
-        NodeIterator iter = parent.getNodes();
+    private boolean hasSiblingWithSameType(Node parent, Node child) throws RepositoryException {

Review comment:
       Looks much cleaner now, but let us use only one parameter `child`. It is easy enough to derive the parent from that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org