You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/11/14 05:23:17 UTC

[1/6] hbase git commit: HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Repository: hbase
Updated Branches:
  refs/heads/branch-1 dbcda15ae -> bac254bd4
  refs/heads/branch-1.1 c4e3ad078 -> 434097db0
  refs/heads/branch-1.2 c2d154ca6 -> 79cc3b314
  refs/heads/branch-1.3 26ff42091 -> dea935dab
  refs/heads/branch-1.4 626d74f79 -> ade166d5f
  refs/heads/branch-2 d0fb4bd78 -> d5df4c042


HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Signed-off-by: Apekshit Sharma <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d5df4c04
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d5df4c04
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d5df4c04

Branch: refs/heads/branch-2
Commit: d5df4c04268bef36e5c0f6f4fc37602c6f77c032
Parents: d0fb4bd
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:05:25 2017 -0600

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/d5df4c04/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index d0d81c6..11f8731 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,21 +431,21 @@ function hbaseanti_patchfile
 
   start_clock
 
-  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+  warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.codehaus.jackson' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.codehaus.jackson' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Jackson 1 classes/annotations: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Jackson 1 classes/annotations."
     ((result=result+1))
   fi
 


[3/6] hbase git commit: HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Posted by bu...@apache.org.
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Signed-off-by: Apekshit Sharma <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/ade166d5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/ade166d5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/ade166d5

Branch: refs/heads/branch-1.4
Commit: ade166d5f80be1a6f57a36b9fc4a8ecee6e40d4d
Parents: 626d74f
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:18:37 2017 -0600

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/ade166d5/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index f70c51b..f9bc7e8 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
 
   start_clock
 
-  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+  warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
     ((result=result+1))
   fi
 


[4/6] hbase git commit: HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Posted by bu...@apache.org.
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Signed-off-by: Apekshit Sharma <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/dea935da
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/dea935da
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/dea935da

Branch: refs/heads/branch-1.3
Commit: dea935dab72afeb4b366bb5307ee69f04a4bc50e
Parents: 26ff420
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:18:46 2017 -0600

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/dea935da/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 24f2ef5..44cbecb 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
 
   start_clock
 
-  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+  warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
     ((result=result+1))
   fi
 


[6/6] hbase git commit: HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Posted by bu...@apache.org.
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Signed-off-by: Apekshit Sharma <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/434097db
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/434097db
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/434097db

Branch: refs/heads/branch-1.1
Commit: 434097db0fe6e7f47097446a4061bf2133ae8b83
Parents: c4e3ad0
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:18:57 2017 -0600

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/434097db/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 24f2ef5..44cbecb 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
 
   start_clock
 
-  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+  warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
     ((result=result+1))
   fi
 


[2/6] hbase git commit: HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Posted by bu...@apache.org.
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Signed-off-by: Apekshit Sharma <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/bac254bd
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/bac254bd
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/bac254bd

Branch: refs/heads/branch-1
Commit: bac254bd4249bbe2d8ccc377409719c9e59c78ae
Parents: dbcda15
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:12:19 2017 -0600

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/bac254bd/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index f70c51b..f9bc7e8 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
 
   start_clock
 
-  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+  warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
     ((result=result+1))
   fi
 


[5/6] hbase git commit: HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Posted by bu...@apache.org.
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of

Signed-off-by: Apekshit Sharma <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/79cc3b31
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/79cc3b31
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/79cc3b31

Branch: refs/heads/branch-1.2
Commit: 79cc3b3145378c994c59c80ca27a1bd9f48f5d75
Parents: c2d154c
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:18:52 2017 -0600

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/79cc3b31/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 24f2ef5..44cbecb 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
 
   start_clock
 
-  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+  warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
     ((result=result+1))
   fi
 
-  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+  warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
   if [[ ${warnings} -gt 0 ]]; then
-    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
     ((result=result+1))
   fi