You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/10/27 19:04:07 UTC
Review Request 63370: Added new --memory_profiling flag to agent and
master binaries.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
This flag allows explicit disabling of the memory profiler
endpoint in the master and agent binaries.
Diffs
-----
src/master/flags.hpp edda71af41a8d199bb24b84487300e9c85b12fec
src/master/flags.cpp 18f405b7e9cc6bd0011284b631974eee52dd2bf3
src/master/main.cpp f65ce637d77ce183f83b70dce6da8d0b4b8b8e71
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
Diff: https://reviews.apache.org/r/63370/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198025
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197860
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198007
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197997
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197855
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 11:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 11:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198029
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197888
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197932
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197985
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197921
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197965
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197916
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197948
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197956
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197989
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197928
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198060
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197969
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
> On Feb. 21, 2018, 9:31 p.m., Mesos Reviewbot Windows wrote:
> > Bad review!
> >
> > Error:
> > Circular dependency detected for review 63367. Please fix the 'depends_on' field.
There was a glitch in the reviewbot code. This was fixed. Sorry for the spam!
- Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198064
-----------------------------------------------------------
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198064
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197864
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197981
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review200894
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 63366.
Failed command: `python.exe .\support\apply-reviews.py -n -r 63366`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63370
Relevant logs:
- [apply-review-63366-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63370/logs/apply-review-63366-stdout.log):
```
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07
> src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea
> src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841
> src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4
> src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9
>
>
> Diff: https://reviews.apache.org/r/63370/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197882
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198051
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198017
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197896
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197892
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 6:41 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 6:41 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197944
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197952
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198013
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198042
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197868
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198033
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197976
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197960
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198037
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197904
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 6:41 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 6:41 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198021
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review201384
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/main.cpp
Lines 369 (patched)
<https://reviews.apache.org/r/63370/#comment282604>
Extra newline.
- Alexander Rukletsov
On April 18, 2018, 4:15 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 4:15 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7944
> https://issues.apache.org/jira/browse/MESOS-7944
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07
> src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea
> src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841
> src/slave/flags.cpp 4ea2286a6a874e6e7f473f97fb0431e17b19c1f8
> src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9
>
>
> Diff: https://reviews.apache.org/r/63370/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/
-----------------------------------------------------------
(Updated April 23, 2018, 9:08 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-7944
https://issues.apache.org/jira/browse/MESOS-7944
Repository: mesos
Description
-------
This flag allows explicit disabling of the memory profiler
endpoint in the master and agent binaries.
Diffs
-----
src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07
src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea
src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841
src/slave/flags.cpp 4ea2286a6a874e6e7f473f97fb0431e17b19c1f8
src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9
Diff: https://reviews.apache.org/r/63370/diff/7/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/
-----------------------------------------------------------
(Updated April 18, 2018, 4:15 a.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-7944
https://issues.apache.org/jira/browse/MESOS-7944
Repository: mesos
Description
-------
This flag allows explicit disabling of the memory profiler
endpoint in the master and agent binaries.
Diffs
-----
src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07
src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea
src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841
src/slave/flags.cpp 4ea2286a6a874e6e7f473f97fb0431e17b19c1f8
src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9
Diff: https://reviews.apache.org/r/63370/diff/7/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/
-----------------------------------------------------------
(Updated April 13, 2018, 6:48 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Changed default to "false".
Repository: mesos
Description
-------
This flag allows explicit disabling of the memory profiler
endpoint in the master and agent binaries.
Diffs (updated)
-----
src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07
src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea
src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841
src/slave/flags.cpp 4ea2286a6a874e6e7f473f97fb0431e17b19c1f8
src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9
Diff: https://reviews.apache.org/r/63370/diff/6/
Changes: https://reviews.apache.org/r/63370/diff/5-6/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197874
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review200901
-----------------------------------------------------------
Bad patch!
Reviews applied: [63370, 63368, 63366, 65462, 65461, 63367]
Failed command: python support/apply-reviews.py -n -r 63366
Error:
2018-04-11 11:25:47 URL:https://reviews.apache.org/r/63366/diff/raw/ [14586/14586] -> "63366.patch" [1]
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22158/console
- Mesos Reviewbot
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07
> src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea
> src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841
> src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4
> src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9
>
>
> Diff: https://reviews.apache.org/r/63370/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198056
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198003
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review198046
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197878
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review197938
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 10:41 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
> src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
> src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
> src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
> src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
> src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
>
>
> Diff: https://reviews.apache.org/r/63370/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/
-----------------------------------------------------------
(Updated Feb. 21, 2018, 10:41 a.m.)
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
This flag allows explicit disabling of the memory profiler
endpoint in the master and agent binaries.
Diffs (updated)
-----
src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d
src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23
src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9
src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e
src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc
src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c
Diff: https://reviews.apache.org/r/63370/diff/3/
Changes: https://reviews.apache.org/r/63370/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review190863
-----------------------------------------------------------
src/master/flags.cpp
Lines 630-635 (patched)
<https://reviews.apache.org/r/63370/#comment268426>
Let's mention here (and below) that --memory_profiling enables profiling but requires jemalloc loaded into the address space of the binary. This can ba achieved by either configurting mesos appropriately or using LD_PRELOD. Other malloc profiling libraries are not supported.
src/master/flags.cpp
Lines 632 (patched)
<https://reviews.apache.org/r/63370/#comment268429>
Let's call it "inactive" for clarity.
- Alexander Rukletsov
On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 7:04 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp edda71af41a8d199bb24b84487300e9c85b12fec
> src/master/flags.cpp 18f405b7e9cc6bd0011284b631974eee52dd2bf3
> src/master/main.cpp f65ce637d77ce183f83b70dce6da8d0b4b8b8e71
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
>
>
> Diff: https://reviews.apache.org/r/63370/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 63370: Added new --memory_profiling flag to agent
and master binaries.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review189678
-----------------------------------------------------------
src/master/flags.cpp
Lines 630-635 (patched)
<https://reviews.apache.org/r/63370/#comment266886>
This looks like a boolean flag, any reason you decided to use a string? It would be nice to keep our boolean enable/disable style flags consistent.
- Benjamin Mahler
On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 7:04 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
>
>
> Diffs
> -----
>
> src/master/flags.hpp edda71af41a8d199bb24b84487300e9c85b12fec
> src/master/flags.cpp 18f405b7e9cc6bd0011284b631974eee52dd2bf3
> src/master/main.cpp f65ce637d77ce183f83b70dce6da8d0b4b8b8e71
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
>
>
> Diff: https://reviews.apache.org/r/63370/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>