You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/08 23:05:48 UTC

[GitHub] [airflow] jarfgit opened a new pull request #18106: Adds LoggingMixins to BaseTrigger

jarfgit opened a new pull request #18106:
URL: https://github.com/apache/airflow/pull/18106


   This is a simple change to add logging to BaseTrigger, making it consistent with other classes like BaseOperator.
   No issue to link to.
   
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jarfgit commented on pull request #18106: Adds LoggingMixins to BaseTrigger

Posted by GitBox <gi...@apache.org>.

jarfgit commented on pull request #18106:
URL: https://github.com/apache/airflow/pull/18106#issuecomment-915633133


   @kaxil @andrewgodwin FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #18106: Adds LoggingMixins to BaseTrigger

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #18106:
URL: https://github.com/apache/airflow/pull/18106#issuecomment-915637220


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #18106: Adds LoggingMixins to BaseTrigger

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #18106:
URL: https://github.com/apache/airflow/pull/18106


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18106: Adds LoggingMixins to BaseTrigger

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #18106:
URL: https://github.com/apache/airflow/pull/18106#issuecomment-915656017


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org