[jira] [Reopened] (LUCENE-6921) Fix SPIClassIterator#isParentClassLoader to don't require extra permissions

["Uwe Schindler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-6921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler reopened LUCENE-6921:
-----------------------------------

I reopening:
The doPrivileged check is inapprop, because the caller's classloader is inspected and not our own. So the caller must have permission.

For Lucene this is no problem, because the caller is responsible for class loaders he creates.

I will remove the doPrivileged check in the SPI check.

> Fix SPIClassIterator#isParentClassLoader to don't require extra permissions
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-6921
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6921
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: Trunk, 5.5
>
>         Attachments: LUCENE-6921.patch, LUCENE-6921.patch
>
>
> This is not really a big issue, because most setups use a "good" context classloader. The context classloader is required by the Java ServiceProvider standard to look for META-INF classes. To work around issues in some setups, the analysis and codec SPIs also scan our own classloader, if it is not a parent of the context one. This check requires permissions, if we are not a parent.
> This will fix the parent check to simply return false (and enforce classpath rescan) if we don't have enough permissions. This is the right thing to do, because if we have no permissions, we are also not a parent!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org