You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/08/01 07:29:56 UTC
Re: Review Request: Add the cgroups isolation module.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5509/#review9669
-----------------------------------------------------------



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/5509/#comment20627>

    Done.



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/5509/#comment20624>

    Done.



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/5509/#comment20628>

    Done.



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/5509/#comment20631>

    Done.



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/5509/#comment20632>

    Done.



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/5509/#comment20633>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20634>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20635>

    Done,



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20644>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20642>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20643>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20636>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20639>

    Done.



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/5509/#comment20640>

    Done.



src/slave/cgroups_isolation_module.hpp
<https://reviews.apache.org/r/5509/#comment20602>

    Done.



src/slave/cgroups_isolation_module.hpp
<https://reviews.apache.org/r/5509/#comment20603>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20604>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20605>

    Remove.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20606>

    Removed.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20607>

    Removed.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20608>

    I don't want to show the stack trace because it is not a bug.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20609>

    Same as above.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20610>

    Done. Refactored.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20611>

    Rafactored.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20612>

    Refactored.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20613>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20614>

    Removed.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20615>

    Removed.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20616>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20623>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20617>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20618>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20619>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20600>

    Done.



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/5509/#comment20601>

    Done.


- Jie Yu


On July 17, 2012, 7:49 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5509/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 7:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Add the cgroups isolation module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 10f1101 
>   src/examples/balloon_executor.cpp PRE-CREATION 
>   src/examples/balloon_framework.cpp PRE-CREATION 
>   src/slave/cgroups_isolation_module.hpp PRE-CREATION 
>   src/slave/cgroups_isolation_module.cpp PRE-CREATION 
>   src/slave/isolation_module.cpp 5b7b4a2 
>   src/tests/cgroups_isolation_tests.cpp PRE-CREATION 
>   src/tests/external/CgroupsIsolation/ROOT_CGROUPS_BalloonFramework.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/5509/diff/
> 
> 
> Testing
> -------
> 
> make check (external test, including OOM tests).
> 
> 
> Thanks,
> 
> Jie Yu
> 
>