[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting 
URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343447
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/AbstractTracerContext.java
 ##########
 @@ -31,6 +31,15 @@
      */
     void inject(ContextCarrier carrier);
 
+    /**
+     * Prepare for the cross-process propagation based on the given exit span. The given exit span should belong to the
+     * current context. How to initialize the carrier, depends on the implementation.
+     *
+     * @param carrier  to carry the context for crossing process.
+     * @param exitSpan to represent the scope of current injection.
+     */
+    void _inject(AbstractSpan exitSpan, ContextCarrier carrier);
 
 Review comment:
   I was wanting people think this could be used as an open API. That is the only repo. Do you want to keep the same method name? `inject`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services