You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mxm (via GitHub)" <gi...@apache.org> on 2024/01/31 12:24:44 UTC
[PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
mxm opened a new pull request, #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768
We have previously removed Flink 1.13 and 1.14 support. See https://issues.apache.org/jira/browse/FLINK-33089. This removes some left-overs and adjusts the version check to work on the last-supported version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on code in PR #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768#discussion_r1473216424
##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -78,8 +78,6 @@ This page serves as a full reference for FlinkDeployment custom resource definit
| Value | Docs |
| ----- | ---- |
-| v1_13 | |
-| v1_14 | |
Review Comment:
Yes, I wonder maybe we could tweak the CRD reference generator to ignore `@Deprecated` fields , that would allow us to nudge users in the right direction :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on code in PR #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768#discussion_r1472756187
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/spec/FlinkVersion.java:
##########
@@ -23,16 +23,14 @@
/** Enumeration for supported Flink versions. */
@Experimental
public enum FlinkVersion {
- v1_13,
- v1_14,
Review Comment:
I guess we need to keep those for the CRD backwards-compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on code in PR #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768#discussion_r1472927104
##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -78,8 +78,6 @@ This page serves as a full reference for FlinkDeployment custom resource definit
| Value | Docs |
| ----- | ---- |
-| v1_13 | |
-| v1_14 | |
Review Comment:
This is generated , so probably can't remove it, maybe we can put a deprecated annotation and improve doc generation for those in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm merged PR #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on code in PR #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768#discussion_r1474249514
##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -78,8 +78,6 @@ This page serves as a full reference for FlinkDeployment custom resource definit
| Value | Docs |
| ----- | ---- |
-| v1_13 | |
-| v1_14 | |
Review Comment:
Yeah, that would be nice. I looked into the doclet generator briefly, but actually adding a JavaDoc comment already allows us to inform users. See https://github.com/apache/flink-kubernetes-operator/pull/768/files?w=1#diff-283ef288346ac9001a197714b5307823f425eb89111554ecb7ab17f81ad9529fR81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on code in PR #768:
URL: https://github.com/apache/flink-kubernetes-operator/pull/768#discussion_r1473197963
##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -78,8 +78,6 @@ This page serves as a full reference for FlinkDeployment custom resource definit
| Value | Docs |
| ----- | ---- |
-| v1_13 | |
-| v1_14 | |
Review Comment:
@gyfora Do the changes look good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org