[GitHub] [cordova-android] raphinesse commented on pull request #1100: refactor!: remove platform binaries

[GitBox <gi...@apache.org>]

raphinesse commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-713428555


   > `android_sdk_version`, which was removed, seems to be called from [cordova-lib](https://github.com/apache/cordova-lib/blob/master/src/plugman/util/default-engines.js#L47). Can it be confirmed that this code in lib is not called in the CLI workflow?
   
   Good catch! Unfortunately this _is_ called during plugin installation as part of the check for the [`<engine>` requirement](https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine) that can be specified in `plugin.xml`.
   
   We will have to keep that too for now. In the long run we should probably change how lib delegates this task to the platforms.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org