You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/01/11 20:47:05 UTC

[GitHub] [pinot] lksvenoy-r7 opened a new issue #7992: RealtimeToOfflineSegmentsTask task timeout is not configurable

lksvenoy-r7 opened a new issue #7992:
URL: https://github.com/apache/pinot/issues/7992


   The task timeout for the RealtimeToOfflineSegments task is not configurable, meaning large tables with large segments can time out when performing the task. In my case, this makes the task useless for some of my larger tables.
   
   Looking at the source code, it looks like all tasks have a hardcoded timeout of 1 hour: https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/PinotTaskGenerator.java#L52 as this is not overwritten in the implementors.
   
   Here's the usage of this timeout:
   https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java#L422
   https://github.com/apache/pinot/blob/master/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTaskGenerator.java
   
   It would be nice to see the default signature on the PinotTaskManager interface removed so that all implementors were forced to implement their own task timeouts (which could default to 1hr) as having configurable task timeouts makes it easier to configure pinot depending on the use cases for various tables.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang closed issue #7992: RealtimeToOfflineSegmentsTask task timeout is not configurable

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7992:
URL: https://github.com/apache/pinot/issues/7992


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7992: RealtimeToOfflineSegmentsTask task timeout is not configurable

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7992:
URL: https://github.com/apache/pinot/issues/7992#issuecomment-1013486298


   #8028 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org