[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #949: IGNITE-17312 Java thin: Implement unified exception handling

[GitBox <gi...@apache.org>]

ptupitsyn commented on code in PR #949:
URL: https://github.com/apache/ignite-3/pull/949#discussion_r925922530


##########
modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java:
##########
@@ -177,21 +181,26 @@ void testHandshakeInvalidVersionReturnsError() throws Exception {
             // Read response.
             var unpacker = MessagePack.newDefaultUnpacker(sock.getInputStream());
             var magic = unpacker.readPayload(4);
-            unpacker.skipValue(3);
-            var len = unpacker.unpackInt();
-            var major = unpacker.unpackInt();
+            unpacker.readPayload(4); // Length.

Review Comment:
   Message length is a raw int32 value, not a MessagePack type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org