You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/09/10 00:51:21 UTC
Re: Review Request 36126: Removing '.json' extension in slave
endpoints url
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36126/#review98295
-----------------------------------------------------------
Ship it!
Minor comments, but it looks shippable to me after those are resolved.
Did you test to verify that the old endpoints still work as expected?
src/slave/monitor.cpp (lines 98 - 99)
<https://reviews.apache.org/r/36126/#comment154643>
As before, please give a version number, so we know when the deprecation cycle actually ends.
src/slave/slave.cpp (lines 497 - 498)
<https://reviews.apache.org/r/36126/#comment154644>
Ditto
src/slave/slave.cpp (line 499)
<https://reviews.apache.org/r/36126/#comment154646>
Please move this below "/health", so we can keep "/state.json" next to "/state".
- Adam B
On Sept. 9, 2015, 12:58 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36126/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 12:58 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2983
> https://issues.apache.org/jira/browse/MESOS-2983
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Removing json extension for HTTP endpoints in slave
>
>
> Diffs
> -----
>
> docs/configuration.md 2b23d48
> docs/network-monitoring.md acd70c5
> src/cli/mesos-cat 73dc63e
> src/cli/mesos-ps ee14d51
> src/cli/mesos-tail 256a804
> src/master/flags.cpp 230c1dc
> src/slave/flags.cpp b36710d
> src/slave/http.cpp b0fe5f5
> src/slave/monitor.cpp 82aa659
> src/slave/slave.hpp 09172f7
> src/slave/slave.cpp 2a99abc
> src/tests/fault_tolerance_tests.cpp 89cb18b
> src/tests/monitor_tests.cpp 53fb53e
> src/tests/slave_tests.cpp d55e9dd
> src/webui/master/static/js/controllers.js 3445028
> src/webui/master/static/js/services.js 2cd9d7d
>
> Diff: https://reviews.apache.org/r/36126/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 36126: Removing '.json' extension in slave
endpoints url
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Sept. 9, 2015, 10:51 p.m., Adam B wrote:
> > Minor comments, but it looks shippable to me after those are resolved.
> >
> > Did you test to verify that the old endpoints still work as expected?
Yes I tested the old endpoints :)
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36126/#review98295
-----------------------------------------------------------
On Sept. 10, 2015, 5:43 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36126/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 5:43 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2983
> https://issues.apache.org/jira/browse/MESOS-2983
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Removing json extension for HTTP endpoints in slave
>
>
> Diffs
> -----
>
> docs/configuration.md 315dc53
> docs/network-monitoring.md acd70c5
> src/cli/mesos-cat 73dc63e
> src/cli/mesos-ps ee14d51
> src/cli/mesos-tail 256a804
> src/master/flags.cpp 230c1dc
> src/slave/flags.cpp 7539441
> src/slave/http.cpp b0fe5f5
> src/slave/monitor.cpp 82aa659
> src/slave/slave.hpp 09172f7
> src/slave/slave.cpp 5e5522e
> src/tests/fault_tolerance_tests.cpp 89cb18b
> src/tests/monitor_tests.cpp 53fb53e
> src/tests/slave_tests.cpp 5c1a3d3
> src/webui/master/static/js/controllers.js 3445028
> src/webui/master/static/js/services.js 2cd9d7d
>
> Diff: https://reviews.apache.org/r/36126/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>