You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/27 15:56:43 UTC
[GitHub] [airflow] dimberman opened a new pull request, #26713: Add documentation to dag test function
dimberman opened a new pull request, #26713:
URL: https://github.com/apache/airflow/pull/26713
Adds a small amount of documentation for the dag.test function
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #26713: Add documentation to dag test function
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #26713:
URL: https://github.com/apache/airflow/pull/26713#discussion_r981591530
##########
airflow/models/dag.py:
##########
@@ -2446,7 +2446,16 @@ def test(
variable_file_path: str | None = None,
session: Session = NEW_SESSION,
) -> None:
- """Execute one single DagRun for a given DAG and execution date."""
+ """
+ Execute one single DagRun for a given DAG and execution date.
+
+ :param execution_date: execution date for the DAG run
+ :param run_conf: configuration to pass to newly created dagrun
+ :param conn_file_path: file path to a connection file in either yaml or json
+ :param variable_file_path: file path to a variable file in either yaml or json
+ :param session: database connection (optional)
+ :return:
Review Comment:
```suggestion
```
We should remove the empty one or add details about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #26713: Add documentation to dag test function
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #26713:
URL: https://github.com/apache/airflow/pull/26713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #26713: Add documentation to dag test function
Posted by GitBox <gi...@apache.org>.
kaxil commented on PR #26713:
URL: https://github.com/apache/airflow/pull/26713#issuecomment-1259903772
@pierrejeambrun Since this feature will be released in 2.5, I am changing the milestone to 2.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org