You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/07 01:36:39 UTC
[GitHub] [cordova-android] breautek opened a new pull request #1022: fix: password prompt
breautek opened a new pull request #1022:
URL: https://github.com/apache/cordova-android/pull/1022
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Password prompt when building release builds is broken and crashes with an exception.
Fixes #1021
### Description
<!-- Describe your changes in detail -->
Adds `System.setProperty("java.awt.headless", "false")` just before building the Swing UI, and resets the property back to true afterwards.
This is required when gradle is set in daemon mode. This [blog](https://www.timroes.de/using-password-prompts-with-gradle-build-files#problem-2--we-dont-have-a-console) explains why.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Manual testing and `npm test`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek edited a comment on pull request #1022: WIP: fix: password prompt
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1022:
URL: https://github.com/apache/cordova-android/pull/1022#issuecomment-654548999
This fixes the prompt issue itself, but there seems to be another issue (described at #1023) where the password is always rejected, but only if the password was provided through the prompt.
I'm not sure if this is still an issue with the prompt itself, or if it's something else in the build script. I'll consider this a WIP for now, I'm still debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek closed pull request #1022: WIP: fix: password prompt
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #1022:
URL: https://github.com/apache/cordova-android/pull/1022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1022: fix: password prompt
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1022:
URL: https://github.com/apache/cordova-android/pull/1022#issuecomment-654548794
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1022?src=pr&el=h1) Report
> Merging [#1022](https://codecov.io/gh/apache/cordova-android/pull/1022?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ec944cf0683d2b01cc5dc636ea6f8738d9e4d019&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1022?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1022 +/- ##
=======================================
Coverage 68.33% 68.33%
=======================================
Files 20 20
Lines 1854 1854
=======================================
Hits 1267 1267
Misses 587 587
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1022?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1022?src=pr&el=footer). Last update [ec944cf...9d009d5](https://codecov.io/gh/apache/cordova-android/pull/1022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1022: WIP: fix: password prompt
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1022:
URL: https://github.com/apache/cordova-android/pull/1022#issuecomment-663642647
Closing because it looks like the new direction is to remove this feature altogether.
https://lists.apache.org/thread.html/rfd8f4c44acf3fc278dda409d2e677ce24ec3a65e34f5b7db5202d5eb%40%3Cdev.cordova.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1022: fix: password prompt
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1022:
URL: https://github.com/apache/cordova-android/pull/1022#issuecomment-654548999
This fixes the prompt issue itself, but there seems to be another issue (described at #1023) where the password is always rejected, but only if the password was provided through the prompt.
I'm not sure if this is still an issue with the prompt itself, or if it's something else in the build script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org